Code review comment for lp:~mwhudson/lava-scheduler/create-private-job

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I think you forgot the prerequisite branch - this makes reading it harder.

60 + try:
61 + bundle_stream = BundleStream.objects.get(pathname=stream)
62 + except BundleStream.DoesNotExist:
63 + raise ValueError("stream %s not found" % stream)

429 + "lava-dashboard",

So it's official (netcraft confirms it). The scheduler depends on the dashboard now. Can we please look at how to merge them? This is a bigger topic. I'd like to get rid of lots of things from the dashboard proper. Perhaps we should move the base models to lava-server (tree-wise) application. lava.silo or lava.testdata or something like that.

« Back to merge proposal