Code review comment for lp:~mwhudson/launchpad/vostok-traverse-distro

On Fri, Jul 30, 2010 at 6:33 AM, Tim Penhey <email address hidden> wrote:

>> if branch_type is a tuple with length != 1, it will blow up in your
>> version, and for a error code path thats undesirable. I haven't done a
>> full review - was glancing in email and this jumped out at me.
>
> Yeah, but branch_type is always a BranchType enum value, which is why I let
> this slide.

From IRC - its good to keep reflexes from having to deal with false
signals - while its true here that its always not a tuple, in the
general case we should be wary of direct substitution like this, so
its nice to have it clearly safe.

-Rob