Code review comment for lp:~mwhudson/launchpad/vostok-traverse-distro

On Thu, 29 Jul 2010 23:44:46 -0000, Tim Penhey <email address hidden> wrote:
> Review: Needs Information
> Agh - perhaps it is just me, but __get_item__ on I<any>Set just seems wrong to
> me.

Changed to getByName.

> > return self.redirectSubTree(canonical_url(distro), status=301)
>
> That will take the user out of the vostok vhost. Is that what you want?

Actually it won't.

> If not, you probably want to set the root as part of the canonical_url call.

I think canonical_url looks at the current request to find the root
site.

I also made the change Rob suggested.

Cheers,
mwh