Launchpad itself

Code review comment for lp:~mwhudson/launchpad/vostok-traverse-distro

  1. vostok-traverse-distro
  2. Merge into devel
Revision history for this message
Robert Collins (lifeless) wrote :

This change is faulty:

- 'Unrecognized branch type: %r' % (branch_type,))
+ 'Unrecognized branch type: %r' % branch_type)

if branch_type is a tuple with length != 1, it will blow up in your version, and for a error code path thats undesirable. I haven't done a full review - was glancing in email and this jumped out at me.

review: Needs Fixing

« Back to merge proposal