Code review comment for lp:~mwhudson/launchpad/vostok-main-template

Revision history for this message
Tim Penhey (thumper) wrote :

> class VostokTestRequest(VostokRequestMixin, LaunchpadTestRequest):
> pass

Instead of pass, how about a docstring?

The browser tests are missing docstrings too. I know they are (most likely)
boring, but should be there anyway.

> def test_distributions(self):
> # VostokRootView.distributions is an iterable of all registered
> # distributions.
> root_view = self.view()

This likes you are actually doing

     VostokRootView.__call__

Is that what you want? I wouldn't have thought so.

Are you familiar at all with the new lp.testing.BrowserTestCase?
It might be better than manually creating the view, initializing it, and
rendering it.

VostokBrowserRequest could benefit from a docstring rather than pass too.

I think that your main-template.pt macro should be a valid HTML file rather
than just <h1> and <div>. I'm pretty sure that most of the HTML in root.pt is
discarded given that it is using the master macro.

review: Needs Information

« Back to merge proposal