Code review comment for lp:~mwhudson/launchpad/recipe-model-code

Revision history for this message
Paul Hummer (rockstar) wrote :

Hi Michael-

  This branch is quite big, and has a lot of really hairy things going on. I know all of this has been discussed on the mailing list, but that's a terrible place to document things. Has anyone put any effort into saying "This is how this works and how you work with it?" Just something to think about.

  This branch looks good. As we discussed, ForbiddenInstruction's docstring needs to be updated to swap "unsupported" for "forbidden." Also, there are a few tests in TestSourcePackageRecipe, and all the methods of TestRecipeBranchRoundTripping that are missing comments/docstrings/some sort of "this is what this test is doing."

Cheers,
Paul

review: Approve

« Back to merge proposal