Launchpad itself

Merge lp:~mwhudson/launchpad/no-more-__used_for__ into lp:launchpad

  1. no-more-__used_for__
  2. Merge into devel
Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Jonathan Lange
Approved revision: no longer in the source branch.
Merged at revision: 11290
Proposed branch: lp:~mwhudson/launchpad/no-more-__used_for__
Merge into: lp:launchpad
Diff against target: 527 lines (+4/-80)
26 files modified
lib/canonical/launchpad/browser/librarian.py (+0/-6)
lib/canonical/launchpad/webapp/tales.py (+0/-3)
lib/canonical/lazr/doc/menus.txt (+0/-5)
lib/lp/answers/browser/faq.py (+0/-2)
lib/lp/blueprints/browser/specification.py (+0/-4)
lib/lp/blueprints/browser/sprint.py (+1/-3)
lib/lp/blueprints/interfaces/specificationdependency.py (+0/-1)
lib/lp/bugs/browser/bugbranch.py (+0/-2)
lib/lp/bugs/browser/cve.py (+0/-2)
lib/lp/code/browser/branch.py (+0/-4)
lib/lp/code/browser/branchlisting.py (+0/-4)
lib/lp/code/browser/branchmergeproposal.py (+0/-7)
lib/lp/code/browser/codeimport.py (+0/-2)
lib/lp/code/browser/codeimportmachine.py (+0/-2)
lib/lp/code/browser/codereviewcomment.py (+0/-1)
lib/lp/code/browser/sourcepackagerecipelisting.py (+1/-6)
lib/lp/registry/browser/codeofconduct.py (+2/-6)
lib/lp/registry/browser/product.py (+0/-2)
lib/lp/registry/browser/productrelease.py (+0/-1)
lib/lp/soyuz/browser/archive.py (+0/-3)
lib/lp/soyuz/browser/build.py (+0/-4)
lib/lp/soyuz/browser/builder.py (+0/-4)
lib/lp/soyuz/browser/publishing.py (+0/-2)
lib/lp/soyuz/browser/queue.py (+0/-1)
lib/lp/soyuz/browser/sourceslist.py (+0/-1)
lib/lp/translations/browser/product.py (+0/-2)
To merge this branch: bzr merge lp:~mwhudson/launchpad/no-more-__used_for__
Reviewer Review Type Date Requested Status
Jonathan Lange (community) Approve
Review via email: mp+31351@code.launchpad.net

Commit message

Remove the no longer relevant __used_for__ attribute from some view classes

Description of the change

Hi,

This _very exciting_ branch removes the __used_for__ declarations from all our browser code. Apparently they're a relic of an old way Zope used to do things, so I deleted them all.

Cheers,
mwh

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/launchpad/browser/librarian.py'
--- lib/canonical/launchpad/browser/librarian.py 2010-03-26 19:19:49 +0000
+++ lib/canonical/launchpad/browser/librarian.py 2010-08-04 04:11:08 +0000
@@ -46,8 +46,6 @@
46 http://launchpad.net/firefox/1.0./1.0.0/+download/firefox-1.0.0.tgz.46 http://launchpad.net/firefox/1.0./1.0.0/+download/firefox-1.0.0.tgz.
47 """47 """
4848
49 __used_for__ = ILibraryFileAlias
50
51 def initialize(self):49 def initialize(self):
52 """Redirect the request to the URL of the file in the Librarian."""50 """Redirect the request to the URL of the file in the Librarian."""
53 # Redirect based on the scheme of the request, as set by Apache in the51 # Redirect based on the scheme of the request, as set by Apache in the
@@ -65,8 +63,6 @@
65class LibraryFileAliasMD5View(LaunchpadView):63class LibraryFileAliasMD5View(LaunchpadView):
66 """View to show the MD5 digest for a librarian file."""64 """View to show the MD5 digest for a librarian file."""
6765
68 __used_for__ = ILibraryFileAlias
69
70 def render(self):66 def render(self):
71 """Return the plain text MD5 signature"""67 """Return the plain text MD5 signature"""
72 self.request.response.setHeader('Content-type', 'text/plain')68 self.request.response.setHeader('Content-type', 'text/plain')
@@ -81,8 +77,6 @@
81 """77 """
82 implements(IBrowserPublisher)78 implements(IBrowserPublisher)
8379
84 __used_for__ = ILibraryFileAlias
85
86 def getFileContents(self):80 def getFileContents(self):
87 # Reset system proxy setting if it exists. The urllib2 default81 # Reset system proxy setting if it exists. The urllib2 default
88 # opener is cached that's why it has to be re-installed after82 # opener is cached that's why it has to be re-installed after
8983
=== modified file 'lib/canonical/launchpad/webapp/tales.py'
--- lib/canonical/launchpad/webapp/tales.py 2010-06-08 15:57:09 +0000
+++ lib/canonical/launchpad/webapp/tales.py 2010-08-04 04:11:08 +0000
@@ -290,7 +290,6 @@
290290
291 """291 """
292 implements(ITraversable)292 implements(ITraversable)
293 __used_for__ = IBrowserApplicationRequest
294293
295 def __init__(self, request):294 def __init__(self, request):
296 self.form = request.form295 self.form = request.form
@@ -340,8 +339,6 @@
340 """Adapter from IApplicationRequest to IRequestAPI."""339 """Adapter from IApplicationRequest to IRequestAPI."""
341 implements(IRequestAPI)340 implements(IRequestAPI)
342341
343 __used_for__ = IApplicationRequest
344
345 def __init__(self, request):342 def __init__(self, request):
346 self.request = request343 self.request = request
347344
348345
=== modified file 'lib/canonical/lazr/doc/menus.txt'
--- lib/canonical/lazr/doc/menus.txt 2010-02-23 13:36:51 +0000
+++ lib/canonical/lazr/doc/menus.txt 2010-08-04 04:11:08 +0000
@@ -105,26 +105,21 @@
105105
106 >>> class RecipeIndexView(LaunchpadView):106 >>> class RecipeIndexView(LaunchpadView):
107 ... """View for summary of a recipe on the cookery facet."""107 ... """View for summary of a recipe on the cookery facet."""
108 ... __used_for__ = IRecipe
109108
110 >>> class RecipeEditInstructionsView(LaunchpadView):109 >>> class RecipeEditInstructionsView(LaunchpadView):
111 ... """View for editing recipe instructions on the cookery facet."""110 ... """View for editing recipe instructions on the cookery facet."""
112 ... __used_for__ = IRecipe
113 ... implements(IRecipeEditMenuMarker)111 ... implements(IRecipeEditMenuMarker)
114112
115 >>> class RecipeEditIngredientsView(LaunchpadView):113 >>> class RecipeEditIngredientsView(LaunchpadView):
116 ... """View for editing recipe ingedients on the cookery facet."""114 ... """View for editing recipe ingedients on the cookery facet."""
117 ... __used_for__ = IRecipe
118 ... implements(IRecipeEditMenuMarker)115 ... implements(IRecipeEditMenuMarker)
119116
120 >>> class RecipeReadJournalView(LaunchpadView):117 >>> class RecipeReadJournalView(LaunchpadView):
121 ... """View for reading a recipe's journal on the cookery facet."""118 ... """View for reading a recipe's journal on the cookery facet."""
122 ... __used_for__ = IRecipe
123 ... implements(IRecipeJournalMenuMarker)119 ... implements(IRecipeJournalMenuMarker)
124120
125 >>> class RecipeQuestionsAllView(LaunchpadView):121 >>> class RecipeQuestionsAllView(LaunchpadView):
126 ... """View for all questions of a recipe on the questions facet."""122 ... """View for all questions of a recipe on the questions facet."""
127 ... __used_for__ = IRecipe
128123
129 # Monkey patch the interfaces and views into the cookingexample module.124 # Monkey patch the interfaces and views into the cookingexample module.
130 >>> cookingexample.IRecipeEditMenuMarker = IRecipeEditMenuMarker125 >>> cookingexample.IRecipeEditMenuMarker = IRecipeEditMenuMarker
131126
=== modified file 'lib/lp/answers/browser/faq.py'
--- lib/lp/answers/browser/faq.py 2009-10-31 15:04:48 +0000
+++ lib/lp/answers/browser/faq.py 2010-08-04 04:11:08 +0000
@@ -57,8 +57,6 @@
57class FAQView(LaunchpadView):57class FAQView(LaunchpadView):
58 """View for the FAQ index."""58 """View for the FAQ index."""
5959
60 __used_for__ = IFAQ
61
62 @property60 @property
63 def label(self):61 def label(self):
64 return self.context.title62 return self.context.title
6563
=== modified file 'lib/lp/blueprints/browser/specification.py'
--- lib/lp/blueprints/browser/specification.py 2009-11-11 15:54:20 +0000
+++ lib/lp/blueprints/browser/specification.py 2010-08-04 04:11:08 +0000
@@ -424,8 +424,6 @@
424class SpecificationSimpleView(LaunchpadView):424class SpecificationSimpleView(LaunchpadView):
425 """Used to render portlets and listing items that need browser code."""425 """Used to render portlets and listing items that need browser code."""
426426
427 __used_for__ = ISpecification
428
429 @cachedproperty427 @cachedproperty
430 def feedbackrequests(self):428 def feedbackrequests(self):
431 if self.user is None:429 if self.user is None:
@@ -457,8 +455,6 @@
457class SpecificationView(SpecificationSimpleView):455class SpecificationView(SpecificationSimpleView):
458 """Used to render the main view of a specification."""456 """Used to render the main view of a specification."""
459457
460 __used_for__ = ISpecification
461
462 @property458 @property
463 def label(self):459 def label(self):
464 return self.context.title460 return self.context.title
465461
=== modified file 'lib/lp/blueprints/browser/sprint.py'
--- lib/lp/blueprints/browser/sprint.py 2009-11-09 04:24:09 +0000
+++ lib/lp/blueprints/browser/sprint.py 2010-08-04 04:11:08 +0000
@@ -140,8 +140,6 @@
140140
141class SprintView(HasSpecificationsView, LaunchpadView):141class SprintView(HasSpecificationsView, LaunchpadView):
142142
143 __used_for__ = ISprint
144
145 implements(IMajorHeadingView)143 implements(IMajorHeadingView)
146144
147 # XXX Michael Nelson 20090923 bug=435255145 # XXX Michael Nelson 20090923 bug=435255
@@ -149,7 +147,7 @@
149 # a second h1 to display. But as this view implements IMajorHeadingView147 # a second h1 to display. But as this view implements IMajorHeadingView
150 # it should not include an h1 below the app buttons.148 # it should not include an h1 below the app buttons.
151 label = None149 label = None
152 150
153 @property151 @property
154 def page_title(self):152 def page_title(self):
155 return '%s (sprint or meeting)' % self.context.title153 return '%s (sprint or meeting)' % self.context.title
156154
=== modified file 'lib/lp/blueprints/interfaces/specificationdependency.py'
--- lib/lp/blueprints/interfaces/specificationdependency.py 2009-06-25 00:00:26 +0000
+++ lib/lp/blueprints/interfaces/specificationdependency.py 2010-08-04 04:11:08 +0000
@@ -46,7 +46,6 @@
4646
47class SpecDependencyIsAlsoRemoval:47class SpecDependencyIsAlsoRemoval:
48 implements(ISpecificationDependencyRemoval)48 implements(ISpecificationDependencyRemoval)
49 __used_for__ = ISpecificationDependency
5049
51 def __init__(self, specdep):50 def __init__(self, specdep):
52 self.specdep = specdep51 self.specdep = specdep
5352
=== modified file 'lib/lp/bugs/browser/bugbranch.py'
--- lib/lp/bugs/browser/bugbranch.py 2009-11-14 10:03:57 +0000
+++ lib/lp/bugs/browser/bugbranch.py 2010-08-04 04:11:08 +0000
@@ -95,8 +95,6 @@
95class BugBranchView(LaunchpadView):95class BugBranchView(LaunchpadView):
96 """Simple view to cache related branch information."""96 """Simple view to cache related branch information."""
9797
98 __used_for__ = IBugBranch
99
100 @cachedproperty98 @cachedproperty
101 def merge_proposals(self):99 def merge_proposals(self):
102 """Return a list of active proposals for the branch."""100 """Return a list of active proposals for the branch."""
103101
=== modified file 'lib/lp/bugs/browser/cve.py'
--- lib/lp/bugs/browser/cve.py 2010-05-21 13:45:56 +0000
+++ lib/lp/bugs/browser/cve.py 2010-08-04 04:11:08 +0000
@@ -116,8 +116,6 @@
116116
117class CveSetView:117class CveSetView:
118118
119 __used_for__ = ICveSet
120
121 def __init__(self, context, request):119 def __init__(self, context, request):
122 self.context = context120 self.context = context
123 self.request = request121 self.request = request
124122
=== modified file 'lib/lp/code/browser/branch.py'
--- lib/lp/code/browser/branch.py 2010-08-02 02:51:42 +0000
+++ lib/lp/code/browser/branch.py 2010-08-04 04:11:08 +0000
@@ -326,8 +326,6 @@
326326
327class BranchView(LaunchpadView, FeedsMixin):327class BranchView(LaunchpadView, FeedsMixin):
328328
329 __used_for__ = IBranch
330
331 feed_types = (329 feed_types = (
332 BranchFeedLink,330 BranchFeedLink,
333 )331 )
@@ -1155,8 +1153,6 @@
1155class BranchMergeQueueView(LaunchpadView):1153class BranchMergeQueueView(LaunchpadView):
1156 """The view used to render the merge queue for a branch."""1154 """The view used to render the merge queue for a branch."""
11571155
1158 __used_for__ = IBranch
1159
1160 @cachedproperty1156 @cachedproperty
1161 def merge_queue(self):1157 def merge_queue(self):
1162 """Get the merge queue and check visibility."""1158 """Get the merge queue and check visibility."""
11631159
=== modified file 'lib/lp/code/browser/branchlisting.py'
--- lib/lp/code/browser/branchlisting.py 2010-05-28 01:44:13 +0000
+++ lib/lp/code/browser/branchlisting.py 2010-08-04 04:11:08 +0000
@@ -1037,14 +1037,10 @@
1037class PersonCodeSummaryView(LaunchpadView):1037class PersonCodeSummaryView(LaunchpadView):
1038 """A view to render the code page summary for a person."""1038 """A view to render the code page summary for a person."""
10391039
1040 __used_for__ = IPerson
1041
10421040
1043class PersonProductCodeSummaryView(PersonCodeSummaryView):1041class PersonProductCodeSummaryView(PersonCodeSummaryView):
1044 """A view to render the code page summary for a `PersonProduct`."""1042 """A view to render the code page summary for a `PersonProduct`."""
10451043
1046 __used_for__ = IPersonProduct
1047
1048 @property1044 @property
1049 def person(self):1045 def person(self):
1050 """Return the person from the context."""1046 """Return the person from the context."""
10511047
=== modified file 'lib/lp/code/browser/branchmergeproposal.py'
--- lib/lp/code/browser/branchmergeproposal.py 2010-06-17 01:16:30 +0000
+++ lib/lp/code/browser/branchmergeproposal.py 2010-08-04 04:11:08 +0000
@@ -550,7 +550,6 @@
550 implements(IBranchMergeProposalActionMenu)550 implements(IBranchMergeProposalActionMenu)
551551
552 label = "Proposal to merge branch"552 label = "Proposal to merge branch"
553 __used_for__ = IBranchMergeProposal
554 schema = ClaimButton553 schema = ClaimButton
555554
556 @action('Claim', name='claim')555 @action('Claim', name='claim')
@@ -782,8 +781,6 @@
782class BranchMergeProposalVoteView(LaunchpadView):781class BranchMergeProposalVoteView(LaunchpadView):
783 """The view used for the tables of votes and requested reviews."""782 """The view used for the tables of votes and requested reviews."""
784783
785 __used_for__ = IBranchMergeProposal
786
787 @property784 @property
788 def show_table(self):785 def show_table(self):
789 """Should the reviewer table be shown at all?786 """Should the reviewer table be shown at all?
@@ -1238,8 +1235,6 @@
1238class BranchMergeProposalSubscribersView(LaunchpadView):1235class BranchMergeProposalSubscribersView(LaunchpadView):
1239 """Used to show the pagelet subscribers on the main proposal page."""1236 """Used to show the pagelet subscribers on the main proposal page."""
12401237
1241 __used_for__ = IBranchMergeProposal
1242
1243 def initialize(self):1238 def initialize(self):
1244 """See `LaunchpadView`."""1239 """See `LaunchpadView`."""
1245 # Get the subscribers and dump them into two sets.1240 # Get the subscribers and dump them into two sets.
@@ -1451,8 +1446,6 @@
1451class FormatPreviewDiffView(LaunchpadView, DiffRenderingMixin):1446class FormatPreviewDiffView(LaunchpadView, DiffRenderingMixin):
1452 """A simple view to render a diff formatted nicely."""1447 """A simple view to render a diff formatted nicely."""
14531448
1454 __used_for__ = IPreviewDiff
1455
1456 @property1449 @property
1457 def preview_diff(self):1450 def preview_diff(self):
1458 return self.context1451 return self.context
14591452
=== modified file 'lib/lp/code/browser/codeimport.py'
--- lib/lp/code/browser/codeimport.py 2010-08-02 03:12:02 +0000
+++ lib/lp/code/browser/codeimport.py 2010-08-04 04:11:08 +0000
@@ -595,8 +595,6 @@
595class CodeImportMachineView(LaunchpadView):595class CodeImportMachineView(LaunchpadView):
596 """The view for the page that shows all the import machines."""596 """The view for the page that shows all the import machines."""
597597
598 __used_for__ = ICodeImportSet
599
600 label = "Import machines for Launchpad"598 label = "Import machines for Launchpad"
601599
602 @property600 @property
603601
=== modified file 'lib/lp/code/browser/codeimportmachine.py'
--- lib/lp/code/browser/codeimportmachine.py 2010-04-23 03:36:24 +0000
+++ lib/lp/code/browser/codeimportmachine.py 2010-08-04 04:11:08 +0000
@@ -56,8 +56,6 @@
56class CodeImportMachineSetView(LaunchpadView):56class CodeImportMachineSetView(LaunchpadView):
57 """The view for the page that shows all the import machines."""57 """The view for the page that shows all the import machines."""
5858
59 __used_for__ = ICodeImportMachineSet
60
61 label = "Import machines for Launchpad"59 label = "Import machines for Launchpad"
6260
63 @property61 @property
6462
=== modified file 'lib/lp/code/browser/codereviewcomment.py'
--- lib/lp/code/browser/codereviewcomment.py 2010-02-19 19:16:32 +0000
+++ lib/lp/code/browser/codereviewcomment.py 2010-08-04 04:11:08 +0000
@@ -113,7 +113,6 @@
113113
114class CodeReviewCommentView(LaunchpadView):114class CodeReviewCommentView(LaunchpadView):
115 """Standard view of a CodeReviewComment"""115 """Standard view of a CodeReviewComment"""
116 __used_for__ = ICodeReviewComment
117116
118 page_title = "Code review comment"117 page_title = "Code review comment"
119118
120119
=== modified file 'lib/lp/code/browser/sourcepackagerecipelisting.py'
--- lib/lp/code/browser/sourcepackagerecipelisting.py 2010-06-15 18:24:04 +0000
+++ lib/lp/code/browser/sourcepackagerecipelisting.py 2010-08-04 04:11:08 +0000
@@ -50,18 +50,13 @@
5050
51class BranchRecipeListingView(RecipeListingView):51class BranchRecipeListingView(RecipeListingView):
5252
53 __used_for__ = IBranch
54
55 branch_enabled = False53 branch_enabled = False
5654
5755
58class PersonRecipeListingView(RecipeListingView):56class PersonRecipeListingView(RecipeListingView):
5957
60 __used_for__ = IPerson
61
62 owner_enabled = False58 owner_enabled = False
6359
6460
65class ProductRecipeListingView(RecipeListingView):61class ProductRecipeListingView(RecipeListingView):
6662 pass
67 __used_for__ = IProduct
6863
=== modified file 'lib/lp/registry/browser/codeofconduct.py'
--- lib/lp/registry/browser/codeofconduct.py 2009-09-15 20:20:20 +0000
+++ lib/lp/registry/browser/codeofconduct.py 2010-08-04 04:11:08 +0000
@@ -35,6 +35,8 @@
35 ICodeOfConduct, ICodeOfConductConf, ICodeOfConductSet,35 ICodeOfConduct, ICodeOfConductConf, ICodeOfConductSet,
36 ISignedCodeOfConduct, ISignedCodeOfConductSet)36 ISignedCodeOfConduct, ISignedCodeOfConductSet)
37from lp.registry.interfaces.person import IPerson37from lp.registry.interfaces.person import IPerson
38
39
38class SignedCodeOfConductSetNavigation(GetitemNavigation):40class SignedCodeOfConductSetNavigation(GetitemNavigation):
3941
40 usedfor = ISignedCodeOfConductSet42 usedfor = ISignedCodeOfConductSet
@@ -183,8 +185,6 @@
183class SignedCodeOfConductAckView(AddView):185class SignedCodeOfConductAckView(AddView):
184 """Acknowledge a Paper Submitted CoC."""186 """Acknowledge a Paper Submitted CoC."""
185187
186 __used_for__ = ICodeOfConduct
187
188 def __init__(self, context, request):188 def __init__(self, context, request):
189 self.context = context189 self.context = context
190 self.request = request190 self.request = request
@@ -261,8 +261,6 @@
261 * set active.261 * set active.
262 """262 """
263263
264 __used_for__ = ISignedCodeOfConduct
265
266 def __init__(self, context, request):264 def __init__(self, context, request):
267 self.context = context265 self.context = context
268 self.request = request266 self.request = request
@@ -304,8 +302,6 @@
304 * clear active.302 * clear active.
305 """303 """
306304
307 __used_for__ = ISignedCodeOfConduct
308
309 def __init__(self, context, request):305 def __init__(self, context, request):
310 self.context = context306 self.context = context
311 self.request = request307 self.request = request
312308
=== modified file 'lib/lp/registry/browser/product.py'
--- lib/lp/registry/browser/product.py 2010-08-03 12:41:29 +0000
+++ lib/lp/registry/browser/product.py 2010-08-04 04:11:08 +0000
@@ -909,7 +909,6 @@
909class ProductView(HasAnnouncementsView, SortSeriesMixin, FeedsMixin,909class ProductView(HasAnnouncementsView, SortSeriesMixin, FeedsMixin,
910 ProductDownloadFileMixin, UsesLaunchpadMixin):910 ProductDownloadFileMixin, UsesLaunchpadMixin):
911911
912 __used_for__ = IProduct
913 implements(IProductActionMenu, IEditableContextTitle)912 implements(IProductActionMenu, IEditableContextTitle)
914913
915 def __init__(self, context, request):914 def __init__(self, context, request):
@@ -1239,7 +1238,6 @@
1239 SortSeriesMixin,1238 SortSeriesMixin,
1240 ProductDownloadFileMixin):1239 ProductDownloadFileMixin):
1241 """View class for the product's file downloads page."""1240 """View class for the product's file downloads page."""
1242 __used_for__ = IProduct
12431241
1244 batch_size = config.launchpad.download_batch_size1242 batch_size = config.launchpad.download_batch_size
12451243
12461244
=== modified file 'lib/lp/registry/browser/productrelease.py'
--- lib/lp/registry/browser/productrelease.py 2010-01-22 03:17:00 +0000
+++ lib/lp/registry/browser/productrelease.py 2010-08-04 04:11:08 +0000
@@ -333,7 +333,6 @@
333333
334class ProductReleaseView(LaunchpadView, ProductDownloadFileMixin):334class ProductReleaseView(LaunchpadView, ProductDownloadFileMixin):
335 """View for ProductRelease overview."""335 """View for ProductRelease overview."""
336 __used_for__ = IProductRelease
337336
338 def initialize(self):337 def initialize(self):
339 self.form = self.request.form338 self.form = self.request.form
340339
=== modified file 'lib/lp/soyuz/browser/archive.py'
--- lib/lp/soyuz/browser/archive.py 2010-08-02 02:13:52 +0000
+++ lib/lp/soyuz/browser/archive.py 2010-08-04 04:11:08 +0000
@@ -807,7 +807,6 @@
807 Implements useful actions and collects useful sets for the page template.807 Implements useful actions and collects useful sets for the page template.
808 """808 """
809809
810 __used_for__ = IArchive
811 implements(IArchiveIndexActionsMenu)810 implements(IArchiveIndexActionsMenu)
812811
813 def initialize(self):812 def initialize(self):
@@ -1819,8 +1818,6 @@
1819class ArchiveBuildsView(ArchiveViewBase, BuildRecordsView):1818class ArchiveBuildsView(ArchiveViewBase, BuildRecordsView):
1820 """Build Records View for IArchive."""1819 """Build Records View for IArchive."""
18211820
1822 __used_for__ = IHasBuildRecords
1823
1824 # The archive builds view presents all package builds (binary1821 # The archive builds view presents all package builds (binary
1825 # or source package recipe builds).1822 # or source package recipe builds).
1826 binary_only = False1823 binary_only = False
18271824
=== modified file 'lib/lp/soyuz/browser/build.py'
--- lib/lp/soyuz/browser/build.py 2010-08-02 02:23:26 +0000
+++ lib/lp/soyuz/browser/build.py 2010-08-04 04:11:08 +0000
@@ -143,7 +143,6 @@
143143
144class BuildView(LaunchpadView):144class BuildView(LaunchpadView):
145 """Auxiliary view class for IBinaryPackageBuild"""145 """Auxiliary view class for IBinaryPackageBuild"""
146 __used_for__ = IBinaryPackageBuild
147146
148 @property147 @property
149 def label(self):148 def label(self):
@@ -234,8 +233,6 @@
234class BuildRetryView(BuildView):233class BuildRetryView(BuildView):
235 """View class for retrying `IBinaryPackageBuild`s"""234 """View class for retrying `IBinaryPackageBuild`s"""
236235
237 __used_for__ = IBinaryPackageBuild
238
239 @property236 @property
240 def label(self):237 def label(self):
241 return 'Retry %s' % self.context.title238 return 'Retry %s' % self.context.title
@@ -348,7 +345,6 @@
348 template/builds-list.pt and callsite details in Builder, Distribution,345 template/builds-list.pt and callsite details in Builder, Distribution,
349 DistroSeries, DistroArchSeries and SourcePackage view classes.346 DistroSeries, DistroArchSeries and SourcePackage view classes.
350 """347 """
351 __used_for__ = IHasBuildRecords
352348
353 page_title = 'Builds'349 page_title = 'Builds'
354350
355351
=== modified file 'lib/lp/soyuz/browser/builder.py'
--- lib/lp/soyuz/browser/builder.py 2010-08-02 02:13:52 +0000
+++ lib/lp/soyuz/browser/builder.py 2010-08-04 04:11:08 +0000
@@ -118,7 +118,6 @@
118118
119class BuilderSetView(LaunchpadView):119class BuilderSetView(LaunchpadView):
120 """Default BuilderSet view class."""120 """Default BuilderSet view class."""
121 __used_for__ = IBuilderSet
122121
123 @property122 @property
124 def label(self):123 def label(self):
@@ -235,7 +234,6 @@
235234
236 Implements useful actions for the page template.235 Implements useful actions for the page template.
237 """236 """
238 __used_for__ = IBuilder
239237
240 @property238 @property
241 def current_build_duration(self):239 def current_build_duration(self):
@@ -262,8 +260,6 @@
262class BuilderHistoryView(BuildRecordsView):260class BuilderHistoryView(BuildRecordsView):
263 """This class exists only to override the page_title."""261 """This class exists only to override the page_title."""
264262
265 __used_for__ = IBuilder
266
267 page_title = 'Build history'263 page_title = 'Build history'
268 binary_only = False264 binary_only = False
269265
270266
=== modified file 'lib/lp/soyuz/browser/publishing.py'
--- lib/lp/soyuz/browser/publishing.py 2010-05-14 08:45:43 +0000
+++ lib/lp/soyuz/browser/publishing.py 2010-08-04 04:11:08 +0000
@@ -194,7 +194,6 @@
194194
195class SourcePublishingRecordView(BasePublishingRecordView):195class SourcePublishingRecordView(BasePublishingRecordView):
196 """View class for `ISourcePackagePublishingHistory`."""196 """View class for `ISourcePackagePublishingHistory`."""
197 __used_for__ = ISourcePackagePublishingHistory
198197
199 @cachedproperty198 @cachedproperty
200 def build_status_summary(self):199 def build_status_summary(self):
@@ -354,7 +353,6 @@
354353
355class BinaryPublishingRecordView(BasePublishingRecordView):354class BinaryPublishingRecordView(BasePublishingRecordView):
356 """View class for `IBinaryPackagePublishingHistory`."""355 """View class for `IBinaryPackagePublishingHistory`."""
357 __used_for__ = IBinaryPackagePublishingHistory
358356
359 def wasCopied(self):357 def wasCopied(self):
360 """Whether or not a binary is published in its original location.358 """Whether or not a binary is published in its original location.
361359
=== modified file 'lib/lp/soyuz/browser/queue.py'
--- lib/lp/soyuz/browser/queue.py 2010-08-02 02:13:52 +0000
+++ lib/lp/soyuz/browser/queue.py 2010-08-04 04:11:08 +0000
@@ -46,7 +46,6 @@
46 template/distroseries-queue.pt and callsite details in DistroSeries46 template/distroseries-queue.pt and callsite details in DistroSeries
47 view classes.47 view classes.
48 """48 """
49 __used_for__ = IHasQueueItems
5049
51 def setupQueueList(self):50 def setupQueueList(self):
52 """Setup a batched queue list.51 """Setup a batched queue list.
5352
=== modified file 'lib/lp/soyuz/browser/sourceslist.py'
--- lib/lp/soyuz/browser/sourceslist.py 2009-09-07 14:54:34 +0000
+++ lib/lp/soyuz/browser/sourceslist.py 2010-08-04 04:11:08 +0000
@@ -31,7 +31,6 @@
31class SourcesListEntriesView(LaunchpadView):31class SourcesListEntriesView(LaunchpadView):
32 """Renders sources.list entries with a Javascript menu."""32 """Renders sources.list entries with a Javascript menu."""
3333
34 __used_for__ = SourcesListEntries
35 template = ViewPageTemplateFile('../templates/sources-list-entries.pt')34 template = ViewPageTemplateFile('../templates/sources-list-entries.pt')
3635
37 def __init__(self, context, request, initially_without_selection=False,36 def __init__(self, context, request, initially_without_selection=False,
3837
=== modified file 'lib/lp/translations/browser/product.py'
--- lib/lp/translations/browser/product.py 2010-02-17 09:33:38 +0000
+++ lib/lp/translations/browser/product.py 2010-08-04 04:11:08 +0000
@@ -82,8 +82,6 @@
8282
83class ProductView(LaunchpadView):83class ProductView(LaunchpadView):
8484
85 __used_for__ = IProduct
86
87 label = "Translation overview"85 label = "Translation overview"
8886
89 @cachedproperty87 @cachedproperty