Code review comment for lp:~mwhudson/launchpad/no-hosted-area-formats-from-codehosting
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On 19/04/10 16:41, Tim Penhey wrote:
> Review: Needs Fixing
> I think it would be better for the branchChanged method to take
> the format strings as three separate parameters rather than a tuple that
> is unpacked.
Yeah, I think you're right.
> We don't really need to test the branchChanged for packs and knits.
OK.
> We should remove the code from the scanner that records the
> formats as part of this (or the next pipe if you wish).
I think we should do that after the pipe that records the formats from
the branch puller, which is a couple of pipes down the line yet...
Interdiff attached.
Cheers,
mwh