Code review comment for lp:~mwhudson/launchpad/incremental-code-imports-bug-512683

Revision history for this message
Tim Penhey (thumper) wrote :

lib/lp/codehosting/codeimport/worker.py

> + if bazaar_tree.branch.last_revision() \
> + == foreign_branch.last_revision():

Our coding standard does suggest to use braces rather than line continuation
characters.

Or even:

    last_revision = bazaar_tree.branch.last_revision()
    if (last_revision == foreign_branch.last_revision()):

Everything else looks good!

  merge approved

review: Approve

« Back to merge proposal