Code review comment for lp:~mwhudson/launchpad/code-import-optimizations
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On 12/04/10 14:16, Tim Penhey wrote:
> Review: Approve
> The change looks fine.
Thanks.
> It does get me wondering a bit why we didn't seem to get any logging when it was pushing the branch to the central store before. Thanks for adding the job started and finished logging bits too.
I think we do actually get logging when pushing to the central store,
but the new log lines should let us see what comes from where :-)
> I agree that it makes more sense to use branch rather than working tree in the workers.
Cool.
Cheers,
mwh