Code review comment for ~mwhudson/debian-cd/+git/ubuntu:only-CD1

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

On Mon, 20 Nov 2023, 18:42 Steve Langasek, <email address hidden>
wrote:

> Review: Needs Fixing
>
>
>
> Diff comments:
>
> > diff --git a/Makefile b/Makefile
> > index bfe1368..b9c957d 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -39,55 +39,31 @@ CAPSUBPROJECT:=" Legacy"
> > endif
> > endif
> > ifndef BINDISKINFO
> > -ifneq ($(MAXCDS),1)
> > -export BINDISKINFO="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION)
> \"$(CAPCODENAME)\" - $(OFFICIAL) $(FULLARCH) Binary-$$num ($$DATE)"
> > -else
> > export BINDISKINFO="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION)
> \"$(CAPCODENAME)\" - $(OFFICIAL) $(FULLARCH) ($$DATE)"
> > endif
> > -endif
> > ifndef SRCDISKINFO
> > -export SRCDISKINFO="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION)
> \"$(CAPCODENAME)\" - $(OFFICIAL) Source-$$num ($$DATE)"
> > +export SRCDISKINFO="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION)
> \"$(CAPCODENAME)\" - $(OFFICIAL) Source-1 ($$DATE)"
>
> But we do produce multiple source ISOs for a release...
> https://cdimage.ubuntu.com/releases/20.04.6/release/source/

Oh oops. Guess I'd better put that back then.

>

« Back to merge proposal