Merge lp:~mwhudson/apport/ignore-new-pycodestyle-warning into lp:~apport-hackers/apport/trunk

Proposed by Michael Hudson-Doyle
Status: Rejected
Rejected by: Brian Murray
Proposed branch: lp:~mwhudson/apport/ignore-new-pycodestyle-warning
Merge into: lp:~apport-hackers/apport/trunk
Diff against target: 17 lines (+2/-2)
1 file modified
test/run (+2/-2)
To merge this branch: bzr merge lp:~mwhudson/apport/ignore-new-pycodestyle-warning
Reviewer Review Type Date Requested Status
Brian Murray Disapprove
Review via email: mp+326575@code.launchpad.net

Description of the change

This should fix the ftbfs in artful. It would be possible to fix the code instead but I'm lazy and most of the uses of except: are probably OK?

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I ended actually fixing most of the bare excepts, so I'm going to close this. Thanks though!

review: Disapprove

Unmerged revisions

3151. By Michael Hudson-Doyle

ignore new warning from pycodestyle

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'test/run'
--- test/run 2016-09-05 21:18:38 +0000
+++ test/run 2017-06-30 04:41:40 +0000
@@ -37,11 +37,11 @@
37 if PYCODESTYLE=$(which pycodestyle 2>/dev/null || which pep8 2>/dev/null); then37 if PYCODESTYLE=$(which pycodestyle 2>/dev/null || which pep8 2>/dev/null); then
38 echo "Running $(basename $PYCODESTYLE)..."38 echo "Running $(basename $PYCODESTYLE)..."
39 # . catches all *.py modules; we explicitly need to specify the programs39 # . catches all *.py modules; we explicitly need to specify the programs
40 $PYCODESTYLE -r --ignore=E401,E402,E501,E124 --exclude=test_problem_report.py,report.py,is-enabled,apport-bug,apport-collect . `find bin data gtk kde -type f -executable`40 $PYCODESTYLE -r --ignore=E401,E402,E501,E124,E722 --exclude=test_problem_report.py,report.py,is-enabled,apport-bug,apport-collect . `find bin data gtk kde -type f -executable`
41 # those tests deliberately have trailing whitespace in test files, ignore41 # those tests deliberately have trailing whitespace in test files, ignore
42 $PYCODESTYLE -r --ignore=E401,E402,E501,W291,W293 test/test_problem_report.py42 $PYCODESTYLE -r --ignore=E401,E402,E501,W291,W293 test/test_problem_report.py
43 # has_key is minidom API, not the dict operator here43 # has_key is minidom API, not the dict operator here
44 $PYCODESTYLE -r --ignore=E401,E402,E501,W601 apport/report.py44 $PYCODESTYLE -r --ignore=E401,E402,E501,W601,E722 apport/report.py
45 else45 else
46 echo "Skipping PEP 8 tests, neither pycodestyle nor pep8 are installed"46 echo "Skipping PEP 8 tests, neither pycodestyle nor pep8 are installed"
47 fi47 fi

Subscribers

People subscribed via source and target branches