Code review comment for lp:~mvo/update-manager/phased-updates

Revision history for this message
Michael Terry (mterry) wrote :

The code itself seems fine.

* OTHER_UNKOWN is a typo, should be OTHER_UNKNOWN

* Might you want to cleanUp from the amd64 setting?

* Running nosetests3, each of the new tests fails with (in addition to a new failure in the pep8 test):
Traceback (most recent call last):
  File "/home/mike/Code/update-manager/trunk/tests/test_update_list.py", line 36, in test_phased_percentage_not_included
    self.assertUpdatesListLen(1)
  File "/home/mike/Code/update-manager/trunk/tests/test_update_list.py", line 28, in assertUpdatesListLen
    origin = list(self.updates_list.pkgs.keys())[0]
IndexError: list index out of range

review: Needs Fixing

« Back to merge proposal