Code review comment for lp:~mvo/ubuntu-app-launch/hide-apps-on-missing-framework

Revision history for this message
Colin Watson (cjwatson) wrote :

This probably does handle the narrow issue at hand of removing the affected .desktop files, but I think it's a mistake to do this in upstart-app-launch. Other hooks may be affected, and we shouldn't have to have every hook handle this independently in order to get consistent results. I would much prefer us to handle this centrally instead.

Why not have click's hook code simply remove the symlinks associated with apps whose framework dependencies aren't satisfied and then re-run the Exec command for each affected hook? The hook's Exec command is supposed to bring the system into sync with the contents of the symlink farm populated by click, so removing entries from that symlink farm should be sufficient to make the .desktop files vanish when the Exec command is run, without the need to change upstart-app-launch at all.

review: Needs Information

« Back to merge proposal