Code review comment for lp:~mvo/software-center/workaround-gtk-regression-lp986186

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hello Michael! So, hmm, on my system it seems I don't see nearly as dramatic a delay when clicking System as you are seeing. For me, it's about 3-4 seconds. That's about the same time as I'm seeing in my Oneiric VM, fully updated. With your branch, it does seem a slight amount faster, maybe about 1/2 second or so. Based on this, I'm not sure that I can say with any confidence that I'm able to reproduce the issue.

The other thing that I'm finding a bit confusing is that the report, bug 986186, appears to be against Software Center 3.0.6 in Oneiric, but this shouldn't be a bug in Oneiric.

However, looking at your code, it looks just fine, and so I will mark this as approved, with the caveat that I appear to be unable to reproduce the actual issue on my own machine, and so cannot verify the fix directly.

And please let me know if I am misunderstanding something! Thanks! :)

review: Approve

« Back to merge proposal