Merge lp:~mvo/software-center/workaround-css-memleak into lp:software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3234
Proposed branch: lp:~mvo/software-center/workaround-css-memleak
Merge into: lp:software-center
Diff against target: 36 lines (+6/-3)
1 file modified
data/ui/gtk3/css/softwarecenter.css (+6/-3)
To merge this branch: bzr merge lp:~mvo/software-center/workaround-css-memleak
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+129830@code.launchpad.net

Description of the change

This branch removes the usage of "text-shadow" as this causes a rather
big memory leak with the current gtk. After talking to mpt about the
subtle visual changes this involved he suggested to remove the text-shadow
permanently as it improves the visual UI. So this branch is doing that
now.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/ui/gtk3/css/softwarecenter.css'
--- data/ui/gtk3/css/softwarecenter.css 2012-07-19 09:29:16 +0000
+++ data/ui/gtk3/css/softwarecenter.css 2012-10-16 09:27:00 +0000
@@ -1,6 +1,11 @@
1@define-color light-aubergine #DED7DB;1@define-color light-aubergine #DED7DB;
2@define-color super-light-aubergine #F4F1F3;2@define-color super-light-aubergine #F4F1F3;
33
4/*
5 do not use text-shadow until bugzilla.gnome.org bug #686209 is
6 fixed - its leaking memory
7*/
8
49
5#featured-star {10#featured-star {
6 border-color: #F89516; /* yellow */11 border-color: #F89516; /* yellow */
@@ -31,7 +36,6 @@
31 -GtkWidget-link-color: shade (@super-light-aubergine, 0.5);36 -GtkWidget-link-color: shade (@super-light-aubergine, 0.5);
32 -GtkWidget-visited-link-color: shade (@super-light-aubergine, 0.6);37 -GtkWidget-visited-link-color: shade (@super-light-aubergine, 0.6);
33 color: shade (@super-light-aubergine, 0.5); /* non-link text color */38 color: shade (@super-light-aubergine, 0.5); /* non-link text color */
34 text-shadow: 0 1 2 lighter (@super-light-aubergine);
35}39}
3640
37.cellrenderer-button {41.cellrenderer-button {
@@ -53,11 +57,10 @@
53 color: darker (@light-aubergine);57 color: darker (@light-aubergine);
54 background-color: shade (@super-light-aubergine, 0.925);58 background-color: shade (@super-light-aubergine, 0.925);
55 border-color: shade (@super-light-aubergine, 0.875);59 border-color: shade (@super-light-aubergine, 0.875);
56 text-shadow: 0 1 2 white;
57}60}
5861
59.frame-header-title {62.frame-header-title {
60 text-shadow: 0 1 2 white;63 /* intentionally left blank */
61}64}
6265
63.item-view-separator {66.item-view-separator {

Subscribers

People subscribed via source and target branches