Code review comment for lp:~mvo/software-center/unity-lens-plus-wildcard-fix

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi Michael, and thanks for doing this work. So, I can see the "Dash Search Plugins" subcategory in the Tweaks&Themes section, and it shows two lenses - the AskUbuntu lens and a Wikipedia lens. However, if I search all categories for the string "unity-lens-" I can actually see quite a few more lenses that are hidden in the technical items. I'm not quite sure how we want to fix this, or even if it is a problem. It seems, however, that we'll want all of the lenses to appear in the subcategory. Please let me know what you think.

Also, could you please describe just a little more detail about the Xapian workaround you added? Is there a bug for this issue by chance? Maybe you could provide a test case to demonstrate how the error is manifested?

Finally, I am getting an error in the new unit test that you added to test_xapian.py. It seems I'm not getting any results back for the query. Possibly it's something simple on my end. Please let me know. Here's the error:

PYTHONPATH=. python tests/test_xapian.py
F......No handlers could be found for logger "softwarecenter.distro.ubuntu"
.
======================================================================
FAIL: test_wildcard_bug1025579_workaround (__main__.AptXapianIndexTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/test_xapian.py", line 126, in test_wildcard_bug1025579_workaround
    self.assertNotEqual(len(mset), 0)
AssertionError: 0 == 0

----------------------------------------------------------------------
Ran 8 tests in 0.097s

FAILED (failures=1)

Many thanks!

« Back to merge proposal