Code review comment for lp:~mvo/software-center/spinner-while-agent-runs-5.2

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi Michael, thanks for this! The code looks fine to me. I especially like that you moved the update-software-center-agent code out of app.py and into the backend.

I know that there was some discussion today about the UI implementation, and I believe that as a result of this you plan to do more work on this branch. I just wanted to approve it as it is in case you decide to stick with it. If you make further changes, I'll be happy to review them.

I do have one question. I noticed that the spinner is only displayed in the application's icon area and the text area to the right still prominently displays the "Not found" message. Would it be better to just show a spinner for the entire view instead? Just wondering what you think about that (since we can't change strings for the SRU, as you mentioned).

review: Approve

« Back to merge proposal