Code review comment for lp:~mvo/software-center/sca-video

Revision history for this message
Michael Vogt (mvo) wrote :

Hi Michael, thanks for your review! The code is mean to redfine it, but its pretty confusing, I will update it to have "html_youtube", "html_viemo", "html_dailymotion" to make it clearer. Its just some test code to allow interactive testing but that is no excuse for it being confusing :)

As for the other question - I'm pretty sure we don't need the extra:
"""
<p><a href="http://vimeo.com/2891554">Supertuxkart 0.6</a> from <a href="http://vimeo.com/user1183699">constantin pelikan</a> on <a href="http://vimeo.com">Vimeo</a>.</p>
"""
as you can configure the "embedd" link directly in their UI to remove those elements.

« Back to merge proposal