Code review comment for lp:~mvo/software-center/sca-video

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hey mvo,

I was just looking at this MP for example html to use... are you meaning to re-define the html variable on (MP lines) 109, 113, 115?

Also, with the snippet:

<iframe src="http://player.vimeo.com/video/2891554?title=0&amp;byline=0&amp;portrait=0" width="400" height="308" frameborder="0" webkitAllowFullScreen allowFullScreen></iframe><p><a href="http://vimeo.com/2891554">Supertuxkart 0.6</a> from <a href="http://vimeo.com/user1183699">constantin pelikan</a> on <a href="http://vimeo.com">Vimeo</a>.</p>

Should we be including all of that on the server rendered version? (I mean, we won't have the vimeo user id, so I'm hoping it's not all required to satisfy the terms). We can obviously include the link to vimeo itself after the iframe, but I'd assumed that when you were speaking earlier about links, that you meant links within the iframe itself?

Cheers,
M

« Back to merge proposal