Merge lp:~mvo/software-center/sca-video-updates into lp:software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 2742
Proposed branch: lp:~mvo/software-center/sca-video-updates
Merge into: lp:software-center
Diff against target: 54 lines (+9/-5)
3 files modified
softwarecenter/db/update.py (+3/-3)
softwarecenter/ui/gtk3/views/appdetailsview.py (+5/-1)
softwarecenter/ui/gtk3/widgets/videoplayer.py (+1/-1)
To merge this branch: bzr merge lp:~mvo/software-center/sca-video-updates
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Michael Nelson Approve
Review via email: mp+92756@code.launchpad.net

Description of the change

Small branch that updates the client to follow the server side changes for videos from software-center-agent.

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Looks great mvo. Let us know if you'd like the config updated for the vimeo iframe size on the vps.

review: Approve
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Thanks mvo! I'll merge now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/db/update.py'
--- softwarecenter/db/update.py 2012-02-11 00:11:47 +0000
+++ softwarecenter/db/update.py 2012-02-13 12:52:12 +0000
@@ -152,7 +152,7 @@
152 'PPA' : 'archive_id',152 'PPA' : 'archive_id',
153 'Screenshot-Url' : 'screenshot_url',153 'Screenshot-Url' : 'screenshot_url',
154 'Thumbnail-Url' : 'thumbnail_url',154 'Thumbnail-Url' : 'thumbnail_url',
155 'Video-Url' : 'video_url',155 'Video-Url' : 'video_embedded_html_url',
156 'Icon-Url' : 'icon_url',156 'Icon-Url' : 'icon_url',
157 'Support-Url' : 'support_url',157 'Support-Url' : 'support_url',
158 'Description' : 'Description',158 'Description' : 'Description',
@@ -185,8 +185,8 @@
185 self.sca_application.description.split("\n")[1:]).strip()185 self.sca_application.description.split("\n")[1:]).strip()
186186
187 # we only support a single video currently :/187 # we only support a single video currently :/
188 if hasattr(self.sca_application, "video_urls"):188 if hasattr(self.sca_application, "video_embedded_html_urls"):
189 self.sca_application.video_url = self.sca_application.video_urls[0]189 self.sca_application.video_embedded_html_url = self.sca_application.video_embedded_html_urls[0]
190190
191 # XXX 2012-01-16 bug=917109191 # XXX 2012-01-16 bug=917109
192 # We can remove these work-arounds once the above bug is fixed on192 # We can remove these work-arounds once the above bug is fixed on
193193
=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
--- softwarecenter/ui/gtk3/views/appdetailsview.py 2012-02-09 13:24:38 +0000
+++ softwarecenter/ui/gtk3/views/appdetailsview.py 2012-02-13 12:52:12 +0000
@@ -1165,8 +1165,12 @@
11651165
1166 # video1166 # video
1167 from softwarecenter.ui.gtk3.widgets.videoplayer import VideoPlayer1167 from softwarecenter.ui.gtk3.widgets.videoplayer import VideoPlayer
1168 mini_hb = Gtk.HBox()
1168 self.videoplayer = VideoPlayer()1169 self.videoplayer = VideoPlayer()
1169 vb.pack_start(self.videoplayer, False, False, 0)1170 mini_hb.pack_start(self.videoplayer, False, False, 0)
1171 # add a empty label here to ensure bg is set properly
1172 mini_hb.pack_start(Gtk.Label(), True, True, 0)
1173 vb.pack_start(mini_hb, False, False, 0)
11701174
1171 # add the links footer to the description widget1175 # add the links footer to the description widget
1172 footer_hb = Gtk.HBox(spacing=6)1176 footer_hb = Gtk.HBox(spacing=6)
11731177
=== modified file 'softwarecenter/ui/gtk3/widgets/videoplayer.py'
--- softwarecenter/ui/gtk3/widgets/videoplayer.py 2012-02-09 20:33:21 +0000
+++ softwarecenter/ui/gtk3/widgets/videoplayer.py 2012-02-13 12:52:12 +0000
@@ -38,7 +38,7 @@
38class VideoPlayer(Gtk.VBox):38class VideoPlayer(Gtk.VBox):
39 def __init__(self):39 def __init__(self):
40 super(VideoPlayer, self).__init__()40 super(VideoPlayer, self).__init__()
41 self.set_size_request(400, 400)41 self.set_size_request(400, 255)
42 self.webkit = WebKit.WebView()42 self.webkit = WebKit.WebView()
43 settings = self.webkit.get_settings()43 settings = self.webkit.get_settings()
44 # this disables the flash and other plugins so that we force html544 # this disables the flash and other plugins so that we force html5

Subscribers

People subscribed via source and target branches