Ubuntu Software Center

Code review comment for lp:~mvo/software-center/review-language-i18n

  1. review-language-i18n
  2. Merge into trunk
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi mvo, thanks for this! So, this looks very cool, but I found one problem when I tried to test using the French locals as shown (I have French langpacks installed on my system):

  LANGUAGE=fr_FR.utf8 LC_ALL=fr_FR.utf8 PYTHONPATH=. python ./software-center

The issue that I see is that there is only a single combobox entry, for "All languages" (in English), and there is no option for "French". And even given that, I see only French reviews in the list:

  http://img811.imageshack.us/img811/506/logithqueubuntu026.png

So, I'm not sure if my test case is somehow not valid/complete, but I thought I'd note it here.

One last thing, this behavior is not coming with this branch. I observe the same in trunk at rev 2675.

Nevertheless, per our conversation in IRC, you'd like to hold off on this in order to fix this one bit, so I'll set this as "Needs Fixing" for tracking.

Thanks!

review: Needs Fixing

« Back to merge proposal