On Wed, Aug 15, 2012 at 09:39:20AM -0000, Kiwinote wrote:
> Review: Approve
>
> The proposed changes are fine - looking at the totality of the file we could simplify it slightly:
> - afaics there is no reason why we should setup the test env - pep8 is a static test
> - we can hardcode in the softwarecenter package for simplicity - the only thing we may change in the future is testing the whole source, we presumably won't go back to testing subpackages
[..]
> Feel free to merge either version, as they both fix the test itself.
Thanks for the feedback, this is good feedback, I simplified the code
now.
On Wed, Aug 15, 2012 at 09:39:20AM -0000, Kiwinote wrote:
> Review: Approve
>
> The proposed changes are fine - looking at the totality of the file we could simplify it slightly:
> - afaics there is no reason why we should setup the test env - pep8 is a static test
> - we can hardcode in the softwarecenter package for simplicity - the only thing we may change in the future is testing the whole source, we presumably won't go back to testing subpackages
[..]
> Feel free to merge either version, as they both fix the test itself.
Thanks for the feedback, this is good feedback, I simplified the code
now.
Cheers,
Michael