Code review comment for lp:~mvo/snappy/snappy-fix-ftbfs-sbuild

The attempt to merge lp:~mvo/snappy/snappy-fix-ftbfs-sbuild into lp:snappy failed. Below is the output from the failed tests.

Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update code.google.com/p/go.crypto failed; trying to fetch newer version
update github.com/blakesmith/ar failed; trying to fetch newer version
code.google.com/p/go.crypto now at 69e2a90ed92d03812364aeb947b7068dc42e561e
update github.com/cheggaaa/pb failed; trying to fetch newer version
github.com/blakesmith/ar now at c9a977dd0cc1392b023382c7bfa5a22af8d3b730
update github.com/jessevdk/go-flags failed; trying to fetch newer version
github.com/cheggaaa/pb now at e8c7cc515bfde3e267957a3b110080ceed51354e
update github.com/mvo5/goconfigparser failed; trying to fetch newer version
github.com/jessevdk/go-flags now at 15347ef417a300349807983f15af9e65cd2e1b3a
update gopkg.in/yaml.v2 failed; trying to fetch newer version
github.com/mvo5/goconfigparser now at 26426272dda20cc76aa1fa44286dc743d2972fe8
update launchpad.net/gocheck failed; trying to fetch newer version
gopkg.in/yaml.v2 now at 49c95bdc21843256fb6c4e0d370a05f24a0bf213
launchpad.net/gocheck now at <email address hidden>
Building
Running tests from /home/tarmac/tmp/tmp.krhn3eL6z3/src/launchpad.net/snappy
=== RUN Test
OK: 16 passed
--- PASS: Test (0.24 seconds)
PASS
coverage: 80.2% of statements
ok launchpad.net/snappy/clickdeb 0.250s coverage: 80.2% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.05 seconds)
PASS
coverage: 12.2% of statements
ok launchpad.net/snappy/cmd/snappy 0.052s coverage: 12.2% of statements
=== RUN Test
OK: 24 passed
--- PASS: Test (0.08 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/coreconfig 0.081s coverage: 100.0% of statements
=== RUN Test
OK: 47 passed
--- PASS: Test (1.04 seconds)
PASS
coverage: 83.3% of statements
ok launchpad.net/snappy/helpers 1.052s coverage: 83.3% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 93.5% of statements
ok launchpad.net/snappy/logger 0.013s coverage: 93.5% of statements
=== RUN Test
OK: 36 passed
--- PASS: Test (0.15 seconds)
PASS
coverage: 81.5% of statements
ok launchpad.net/snappy/partition 0.150s coverage: 81.5% of statements
=== RUN Test
OK: 3 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/pkg 0.003s coverage: 100.0% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.07 seconds)
PASS
coverage: 94.3% of statements
ok launchpad.net/snappy/policy 0.069s coverage: 94.3% of statements
=== RUN Test
OK: 3 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 84.8% of statements
ok launchpad.net/snappy/priv 0.004s coverage: 84.8% of statements
=== RUN Test
OK: 4 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 50.0% of statements
ok launchpad.net/snappy/progress 0.010s coverage: 50.0% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/release 0.006s coverage: 100.0% of statements
=== RUN Test
drwxr-xr-x root/root 0 2015-05-20 03:11 ./bin
-rwxr-xr-x root/root 31 2015-05-20 03:11 ./bin/hello-world
-rw-rw-rw- root/root 0 2015-05-20 03:11 ./file-with-perm
drwxr-xr-x root/root 0 2015-05-20 03:11 ./meta
-rw-r--r-- root/root 57 2015-05-20 03:11 ./meta/package.yaml
-rw-r--r-- root/root 28 2015-05-20 03:11 ./meta/readme.md
lrwxrwxrwx root/root 0 2015-05-20 03:11 ./symlink -> bin/hello-world
drwxrwxrwx root/root 0 2015-05-20 03:11 ./tmp

foo foo-fork
OK: 257 passed
--- PASS: Test (7.60 seconds)
PASS
coverage: 80.0% of statements
ok launchpad.net/snappy/snappy 7.609s coverage: 80.0% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.51 seconds)
PASS
coverage: 77.4% of statements
ok launchpad.net/snappy/systemd 0.518s coverage: 77.4% of statements
Running vet
Running lint
Lint complains:
logger/logger_test.go:119:26: error strings should not end with punctuation

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/snappy
cp -a . $GOPATH/src/launchpad.net/snappy/
cd $GOPATH/src/launchpad.net/snappy

./run-checks

if which goctest >/dev/null; then
    goctest="goctest"
else
    goctest="go test"
fi

echo Checking formatting
fmt=$(gofmt -l .)

if [ -n "$fmt" ]; then
    echo "Formatting wrong in following files"
    echo $fmt
    exit 1
fi

echo Installing godeps
go get launchpad.net/godeps
export PATH=$PATH:$GOPATH/bin

echo Install golint
go get github.com/golang/lint/golint
export PATH=$PATH:$GOPATH/bin

echo Obtaining dependencies
godeps -u dependencies.tsv

echo Building
go build -v launchpad.net/snappy/...
github.com/blakesmith/ar
launchpad.net/snappy/helpers
launchpad.net/snappy/logger
code.google.com/p/go.crypto/ssh/terminal
github.com/jessevdk/go-flags
launchpad.net/snappy/clickdeb
launchpad.net/snappy/pkg
launchpad.net/snappy/priv
github.com/cheggaaa/pb
github.com/mvo5/goconfigparser
gopkg.in/yaml.v2
launchpad.net/snappy/progress
launchpad.net/snappy/policy
launchpad.net/snappy/release
launchpad.net/snappy/systemd
launchpad.net/snappy/coreconfig
launchpad.net/snappy/partition
launchpad.net/snappy/snappy
launchpad.net/snappy/cmd/snappy

# tests
echo Running tests from $(pwd)
$goctest -v -cover ./...

# go vet
echo Running vet
go vet ./...

# golint
echo Running lint
lint=$(golint ./...)
if [ -n "$lint" ]; then
    echo "Lint complains:"
    echo $lint
    exit 1
fi