~mvo/snapd/+git/snapd-mvo:run-fontconfig-2.36

Last commit made on 2018-11-27
Get this branch:
git clone -b run-fontconfig-2.36 https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
run-fontconfig-2.36
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

4c2355a... by Michael Vogt

snapstate: only run fontconfig update on classic

2d35eda... by Michael Vogt

tests: fix fontconfig extension

a64a3d1... by Michael Vogt

snapstate: update fontconfig caches on install

A common issue with snap is that the embedded fontconfig library
does not match the version on the host. This may lead to very
slow startup times of applications because the fontconfig caches
must be generated on first-run. This is bad user experience.

This PR is a very simplistic fix that will generate the two most
common versions of fontconfig caches on package install/refresh.
The fc-cache command is extremly quick (0m0,020s on my system)
if the caches are up-to-date so it seems to be fine to just run
it always.

There are various more options:
- run fc-cache only for classic and desktop snaps
- do not (ab)use link-snap but instead we could:
  a) implement a fontconfig security backend
  b) add a fontconfig specific task
- a virtual hook (but it would need to run unconfined)

I'm happy about suggestions how to make this more elaborate if
desired.

73d80db... by Samuele Pedroni

Revert "cmd/snap, tests/main/snap-info: highlight the current channel" (2.36)

This reverts commit 40e2991 (#5848).

533761c... by John Lenton

Revert "cmd/snap, tests/main/snap-info: highlight the current channel"

This reverts commit 40e299154324315957d31eb89823c5267c0d9e85.

84e5ab2... by Maciej Borzecki

cmd/snap: add nanosleep to blacklisted syscalls when running with --strace (#6155)

* cmd/snap: add nanosleep to blacklisted syscalls when running with --strace

Strace was observed to block on nanosleep when using `snap run --strace` with an
app from snap built using core18 base on a 4.19.1 kernel host. This is how it
looked like:

  $ snap run --strace test-snapd-tools-core18.echo foo
  [pid 4859] execve("/snap/test-snapd-tools-core18/2/bin/echo", ["/snap/test-snapd-tools-core18/2/"..., "foo"], 0xc0000c2700 /* 54 vars */ <unfinished ...>
  [pid 4861] <... nanosleep resumed> NULL) = 0

Blacklisting nanosleep() made it unblock.

Signed-off-by: Maciej Borzecki <email address hidden>

* snap: run `go fmt` on cmd_run_test.go with go1.10

ad07f12... by Zygmunt Krynicki

tests: add regression test for LP: #1803535

Signed-off-by: Zygmunt Krynicki <email address hidden>

069f5aa... by Zygmunt Krynicki

snap-update-ns: fix trailing slash bug on trespassing error

The trespassing detector is handled unclean paths, belonging to
subsequently growing substring of the constructed path. Such paths can
easily end with a trailing slash.

Fixes: https://bugs.launchpad.net/snapd/+bug/1803535
Signed-off-by: Zygmunt Krynicki <email address hidden>

2a9b4de... by Maciej Borzecki

interfaces/builtin/opengl: allow reading /etc/OpenCL/vendors

/etc/OpenCL vendors contains vendor specific ICD files. Make sure that snap can
read it to assemble a desired set of OpenCL vendor implementations.

Signed-off-by: Maciej Borzecki <email address hidden>

2aa2f22... by Maciej Borzecki

cmd/snap-confine: nvidia: pick up libnvidia-opencl.so

Pick up Nvidia's OpenCL implementation from the host fs.

Signed-off-by: Maciej Borzecki <email address hidden>