debian: ensure leftover usr.lib.snapd.snap-confine is gone
In commit 0dce4704a5d (2017-03-28, snapd v2.23.6) we renamed
/etc/apparmor.d/usr.lib.snap-confine to usr.lib.snap-confine.real
to fix LP: #1673247 - however some people (upgrades?) still have
the old usr.lib.snap-confine file. This seems to be loaded instead
of the correct usr.lib.snap-confine.real profile. To fix this we
use the rather blunt approach to remove the file forcefully if
it is unchanged.
cmd/snap, overlord/snapstate: silently ignore classic flag when a snap is strictly confined (#6477)
When installing a strict snap withthe --classic snap like:
snap install strict-snap --classic
this should be allowed because the user expresses that he/she is willing to install a classic snap.
If the snap is not classic that is even better and no reason to error (a warning is appropriate to
ensure the user is not under the misconception that the snap gets installed with classic confinement).
* overlord/snapstate: silently ignore classic flag when installing a non classic snap
Signed-off-by: Maciej Borzecki <email address hidden>
* cmd/snap: warn when --classic flag was ignored
Signed-off-by: Maciej Borzecki <email address hidden>
* overlord/snapstate: review feedback
Signed-off-by: Maciej Borzecki <email address hidden>
* tests/main/install-errors: verify --classic flag for non-classic snaps
Signed-off-by: Maciej Borzecki <email address hidden>
* cmd/snap: display warning before snap install summary
Signed-off-by: Maciej Borzecki <email address hidden>
* tests/main/install-errors: fix error match
Signed-off-by: Maciej Borzecki <email address hidden>
* travis: quote Go version
Signed-off-by: Maciej Borzecki <email address hidden>
cmd/snap, overlord/snapstate: silently ignore classic flag when a snap is strictly confined (#6477)
When installing a strict snap withthe --classic snap like:
snap install strict-snap --classic
this should be allowed because the user expresses that he/she is willing to install a classic snap.
If the snap is not classic that is even better and no reason to error (a warning is appropriate to
ensure the user is not under the misconception that the snap gets installed with classic confinement).
* overlord/snapstate: silently ignore classic flag when installing a non classic snap
Signed-off-by: Maciej Borzecki <email address hidden>
* cmd/snap: warn when --classic flag was ignored
Signed-off-by: Maciej Borzecki <email address hidden>
* overlord/snapstate: review feedback
Signed-off-by: Maciej Borzecki <email address hidden>
* tests/main/install-errors: verify --classic flag for non-classic snaps
Signed-off-by: Maciej Borzecki <email address hidden>
* cmd/snap: display warning before snap install summary
Signed-off-by: Maciej Borzecki <email address hidden>
* tests/main/install-errors: fix error match
Signed-off-by: Maciej Borzecki <email address hidden>
* travis: quote Go version
Signed-off-by: Maciej Borzecki <email address hidden>