~mvo/snapd/+git/snapd-mvo:debhelper-oh-please

Last commit made on 2019-02-14
Get this branch:
git clone -b debhelper-oh-please https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
debhelper-oh-please
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

2495edc... by Michael Vogt

Merge remote-tracking branch 'upstream/master' into debhelper-oh-please

22ca81a... by Michael Vogt

Merge pull request #6510 from mvo5/disable-names

tests: stop catalog-update test for now

5bc0399... by Michael Vogt

tests: stop catalog-update/apt-hooks test for now

The store is unhappy currently and won't answer to requests for
names. So this test always fails. Once the store is happy again
we can re-enable this test.

30df251... by Michael Vogt

snap-confine: improve comment in "core"->"ubuntu-core" fallback handling

5a4ce86... by Michael Vogt

tests: add upgrade test from 2.15.2ubuntu1 -> current

a549ccd... by Michael Vogt

snap-confine: fix fallback to ubuntu-core

f6828f4... by Michael Vogt

packaging: avoid race in snapd.postinst

We need to run dh_apparmor before dh_systemd_enable so that
the snapd.postinst is written in the right way.

The old code was doing things in the *wrong* order:
- it (re)starts snapd first
- it reloads the snap-confine apparmor profile *after* that
which of course means that on an upgrade there is a time window
in which snapd is available for the system-key check but
snap-confine has an old profile and will die because it tries
to do things that it cannot do with that old profile.

Together with the removal of "snapd.framework.target" this
race caused real world upgrades to stop snaps.

20e9175... by Michael Vogt

Merge pull request #6501 from pedronis/auto-refresh-private-no-cache

 tests/main/auto-refresh-private: make sure to actually download with the expired macaroon

a895e53... by "John R. Lenton" <email address hidden>

many: save media info when installing, show it when listing (#6034)

Before this change, `media` wasn't part of the `/v2/snaps` nor
`/v2/snaps/<snap>` endpoints' responses.

This change:

* in `overlord/snapstate/backend`, it adds the `ExtraInfo` type,

  ```
  // ExtraInfo is information about a snap that is not in the snap.yaml,
  // not needed in the state, but may be cached to augment the
  // information returned for locally-installed snaps
  ```
  > initially, `ExtraInfo` holds just a `snap.MediaInfos`.

  It also adds two methods to managerBackend:

  * `SaveExtraInfo` which saves an `ExtraInfo` for a given snap, and
  * `DeleteExtraInfo` which removes it

  > initially these two are very simplistic, writing it out as json to
  > a directory, one file per snap name.

  Lastly it adds a `backend.LoadExtraInfo` which fills in the fields
  of a passed-in `*snap.Info`.

* in `overlord/snapstate`, it adds `"save-extra-info"` and
  `"delete-extra-info"` tasks and handlers that call the corresponding
  methods in the backend. It also adds a flag for `readInfo` to call
  `backend.LoadExtraInfo`, and changes `(*SnapState).CurrentInfo()`'s
  `readInfo` call to use that flag.

  Lots of tests tweaks here to accommodate the new tasks (bleeding
  over into `hookstate`).

* in `daemon`, it updates `mapLocal` to now copy `Media`. With the
  above changes, this means that the returned snaps from `/v2/snaps`
  (as well as `/v2/snaps/<snap>`) now have `media` popuplated as long
  as `select=all` isn't used. I thought this reasonable as a first
  step (I don't even know if any `media`-using frontends use
  `select=all`).

tadaah...
```json
// ...
  "installed-size": 131207168,
  "jailmode": false,
  "media": [
    {
      "type": "screenshot",
      "url": "https://dashboard.snapcraft.io/site_media/appmedia/2018/05/trackmania.png"
    },
    {
      "type": "screenshot",
      "url": "https://dashboard.snapcraft.io/site_media/appmedia/2018/06/tnmationsforver640x360.gif"
    }
  ],
  "mounted-from": "/var/lib/snapd/snaps/tmnationsforever_26.snap",
  "name": "tmnationsforever",
// ...
```

b990150... by Samuele Pedroni

make sure this test actually downloads with the expired macaroon