~mvo/snapd/+git/snapd-mvo:damon-shutdown-timeout

Last commit made on 2019-06-19
Get this branch:
git clone -b damon-shutdown-timeout https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
damon-shutdown-timeout
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

8164235... by Michael Vogt

daemon: increase `shutdownTimeout` to 25s to deal with slow HW

We got a bugreport from a customer that they get core refresh
errors. We see the following error in the journal:
```
cannot gracefully finish, still active connections...
```

This indicates that the HW is just too slow to deal with this
in the 5s timeout. This means that snapd does not exit cleanly
and systemd will restart it. This will mean that snapd gets
to WaitRestart() again and assumes a system restart has happend
(but only snapd was restarted). This leads to an abort of the
install as it looks (for snapd) like there was a rollback during
the reboot because the core revision has not changed.

There are multiple issues here that needs addressing. The first
one is that the timeout needs to be bigger and that it should
not be an error but a warning. The error in this situation will
not stop the shutdown so the still-connected client do not
benefit and the side-effect of the unclean exit is undesired.

So this PR increases the timeout and turns the error into a
warning.

918e5d6... by Michael Vogt

Merge pull request #7008 from bboozzoo/bboozzoo/completion-for-classic-execdir

cmd/snap-exec: fix snap completion for classic snaps with non /usr/lib/snapd libexecdir

60f5d5a... by Maciej Borzecki

Merge pull request #6680 from bboozzoo/bboozzoo/pprof

daemon: expose pprof endpoints

b20451b... by Maciej Borzecki

cmd/snap-exec: tweak test data to make it less confusing

Signed-off-by: Maciej Borzecki <email address hidden>

d15ba5a... by Maciej Borzecki

Merge remote-tracking branch 'origin/master' into bboozzoo/completion-for-classic-execdir

ce26992... by Michael Vogt

Merge pull request #7012 from bboozzoo/bboozzoo/osx-no-snap-pack

travis: disable snap pack on OSX

752a870... by Maciej Borzecki

travis: disable snap pack on OSX

Relevant build log:

Cloning into '/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle'...
remote: Enumerating objects: 81, done.
remote: Counting objects: 100% (81/81), done.
remote: Compressing objects: 35% (26remote: Compressing objects: 100% (74/74), done.
remote: Total 81 (delta 7), reused 27 (delta 4), pack-reused 0
Unpacking objects: 100% (81/81), done.
Tapped 0 formulae (172 files, 244.2KB)
Error: undefined method `present?' for nil:NilClass
Please report this bug:
    https://github.com/Homebrew/homebrew-bundle/issues/
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle/lib/bundle/brewfile.rb:12:in `path'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle/lib/bundle/brewfile.rb:26:in `read'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle/lib/bundle/commands/install.rb:9:in `run'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle/cmd/brew-bundle.rb:75:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/utils.rb:18:in `require?'
/usr/local/Homebrew/Library/Homebrew/brew.rb:105:in `<main>'
Error: Kernel.exit

Signed-off-by: Maciej Borzecki <email address hidden>

8709aed... by Maciej Borzecki

cmd/snap-exec: tweak how completion helper is looked up

Implement a finer lookup for the completion helper, under the assumption that
the helper always exists in the same directory as snap-exec.

Signed-off-by: Maciej Borzecki <email address hidden>

51eac71... by "John R. Lenton" <email address hidden>

Merge pull request #7001 from chipaca/cohorts-snap-ops

client, cmd/snap: expose the new cohort options for snap ops

9d4e5e4... by John Lenton

cmd/snap: tweaks to messages and use local variables for switch

This addresses review feedback from @pedronis and @stolowski (thanks!)