~mvo/snapd/+git/snapd-mvo:core18-only-restart-when-needed

Last commit made on 2018-12-13
Get this branch:
git clone -b core18-only-restart-when-needed https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
core18-only-restart-when-needed
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

c85754b... by Michael Vogt

address review feedback

b52d8f5... by Michael Vogt

wrappers: only restart service in core18 when they are active

This fixes the issue that on the very first boot the
snapd.seeded.service must not be restarted. This service has a
"Requires=snapd.socket" relation and that means that when we
seed and we start snapd.socket for the first time we must not
stop it or otherwise systemd will also stop snapd.seeded.service
which will means that systemd will start the units configured with
"After=snapd.seeded.service" which would be too early.

634293e... by Michael Vogt

Merge pull request #6295 from mvo5/no-restart

systemd: start snapd.autoimport.service in --no-block mode

2946227... by Michael Vogt

Merge pull request #6297 from bboozzoo/bboozzoo/fedora-snappy-if-fix

data/selinux: fix syntax error in definition of snappy_admin interface

9634550... by Paweł Stołowski

Merge pull request #6180 from stolowski/implicit-hooks-interfaces

snap/info: bind global plugs/slots to implicit hooks

4dcf8fc... by Maciej Borzecki

data/selinux: fix syntax error in definition of snappy_admin interface

The snappy_admin interface in snappy.if is incorrectly defined. It is missing a
start quote in the interface name. This causes sepolgen-ifgen to raise an error
when installing selinux-policy-devel package. The error is logged as follows:

/usr/share/selinux/devel/include/contrib/snappy.if: Syntax error on line 260 gen_require [type=GEN_REQ]
/usr/share/selinux/devel/include/contrib/snappy.if: Syntax error on line 263 ' [type=SQUOTE]
/usr/share/selinux/devel/include/contrib/snappy.if: Syntax error on line 273 ' [type=SQUOTE]

Fixes:
  https://bugzilla.redhat.com/show_bug.cgi?id=1658152

Signed-off-by: Maciej Borzecki <email address hidden>

adf912f... by Michael Vogt

systemd: start snapd.autoimport.service in --no-block mode

When seeding in core18 we need to make sure that the
snadpd.autoimport.service is started in non-blocking mode. Otherwise
it would wait forever because it has a "After=snapd.seeding.service"
but the snapd.seeding.service will only finish if the code that
writes the core18 snapd units can run. So this prevents a deadlock.

Note that by starting it with --no-block the right thing will happen,
i.e. the unit is starting but waits until the snapd.seeded.service
is done and then it will run (which is what we want).

b6c852d... by Paweł Stołowski

Make toplevelSlots/Plugs private (thanks Samuele!).

6fc6cea... by Paweł Stołowski

Removed unneeded extra init code.

7901dbb... by Paweł Stołowski

Extra new line.