Merge lp:~mvo/snapcraft/docs-1 into lp:~snappy-dev/snapcraft/core
Proposed by
Michael Vogt
on 2015-07-24
| Status: | Rejected |
|---|---|
| Rejected by: | Michael Terry on 2015-07-29 |
| Proposed branch: | lp:~mvo/snapcraft/docs-1 |
| Merge into: | lp:~snappy-dev/snapcraft/core |
| Diff against target: |
99 lines (+81/-0) 3 files modified
README.md (+7/-0) docs/intro.md (+71/-0) docs/tutorial.md (+3/-0) |
| To merge this branch: | bzr merge lp:~mvo/snapcraft/docs-1 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry (community) | Disapprove on 2015-07-29 | ||
| Leo Arias | 2015-07-24 | Needs Fixing on 2015-07-24 | |
|
Review via email:
|
|||
Description of the Change
Start working on the docs:
- rename README.md to HACKING.md as its about snapcraft hacking
- add new README.md that points to the docs under doc/
- add docs/intro.md that explains some of the key concepts
- add stub docs/tutorial.md
To post a comment you must log in.
lp:~mvo/snapcraft/docs-1
updated
on 2015-07-24
- 107. By Michael Vogt on 2015-07-24
-
expand why we need parts at all
| Michael Terry (mterry) wrote : | # |
A few comments too. Thanks for this work, mvo!
| Daniel Holbach (dholbach) wrote : | # |
Great work. After Mike's review there was only one more comment to leave. :-)
| Michael Terry (mterry) wrote : | # |
mvo is on vacation for two weeks, I'll take this branch over in a new MP.
| Michael Terry (mterry) wrote : | # |
review:
Disapprove


Some small typos, but this is great and clear. Thank you!