Code review comment for lp:~mvo/pkgme-devportal/add-configuration-for-library-overrides

Revision history for this message
Jonathan Lange (jml) wrote :

 * Really like splitting 'configuration' into a different module. Thanks.
 * ``write_config`` should probably be a Fixture that just sets the config. Not necessary to change in this branch, but if you're feeling
 * I would have thought that the config should be '<library>: <recommended package>'. I don't know if I'm right or you're right or even if the patch should be changed at this point in the absence of data. Probably OK to merge.
 * There really ought to be an example configuration that shows this
 * We're probably going to want a web control for this. Pinging LOSAs every time we want to add something is going to suck.

review: Approve

« Back to merge proposal