Code review comment for lp:~mvo/oneconf/mvo

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Oh, I got stopped between two commits to get some food tonight and got some issues fixed before looking at my email :)
This are good stuff still even if some are duplicated, the only part I won't take is:
130 -sys.path.append(os.path.abspath(os.path.dirname(os.path.dirname(os.path.realpath(__file__)))))
131 +sys.path.append("/usr/share/oneconf")

-> This prevent me symlinking from trunk for testing. I want at some point to get rid of /usr/share/oneconf which is hardcoded in setup.py as well.
I removed python-desktopcouch dep you added as well as python-desktopcouch is a transitional package (in universe) depending on desktopcouch which contains the real desktopcouch thing.

Thanks a lot for your patches there :)

BTW, on my 32 machine, I don't have crashes in that part. will worth having a look at this (threading issue?)

review: Approve

« Back to merge proposal