Code review comment for lp:~mvo/launchpad/support-timeframe-fix-660433

Revision history for this message
Robert Collins (lifeless) wrote :

On Fri, Oct 15, 2010 at 8:57 PM, Michael Vogt <email address hidden> wrote:
> Hey Robert, thanks for your review. I'm happy to remove the data. Please note that its empty gz files currently, so the data added to bzr should be small. But I'm fine with removing it as its currently not required (something small binray (one or two stanzas will be required when we test the germinate output though, so advise is welcome how to handle this).

We already have such data elsewhere in the tree, or we can generate it
on demand.

We're currently working on parallel testing too, which means that
tests *cannot* depend on mutating data in the tree.

(and yes, you'll need to have it be a python unittest).

-Rob

« Back to merge proposal