dee

Code review comment for lp:~mvo/dee/small-python-fixes

Revision history for this message
Michal Hruby (mhr3) wrote :

> On Tue, Sep 11, 2012 at 02:53:30PM -0000, Michal Hruby wrote:
> > Thanks for these
> >
> > 8 - self.set_schema_full (tuple(args), len(args))
> > 9 + self.set_schema_full (tuple(args))
> >
> > Would be nice if pygobject didn't change something every other version :(
> Ideally there should be a way to make it work with new as well as old
> pygobject (doesn't pygobject provide it's version in some prop?)
>
> Since recently there is a gi.version_info that could be used, but its
> not available on precsie and I don't know when exactly it was added
> (nor when exactly the bindings broke).
>
> So I think there these options:
>
> - simply require latest python-gi and change unconditionally
>
> - I could do a try/except AttributeError but that carries the risk that
> it shadows other errors so I'm not really advocating it.
>

As long as it works on both P and Q, I'm fine with it, we don't need to support every version combination... And +1 for avoiding the use of try except.

Could you also link a bug about this pls?

« Back to merge proposal