Code review comment for lp:~mvo/click/lp1358294-config-removal

This is a code review only; I think deleting user data in this way is fundamentally misguided, but since I'm stepping back from the click project in general I don't really want to get into that argument. The "Needs Fixing" applies only to making the tests more robust, as suggested in inline comments.

It is not at all obvious to me from the bug trail that Jamie's comment #15 has been resolved. Comment #13 only says that we "can" display a warning, but there's no bug task for that (unity-scope-click?) and no indication that this has in fact been done. I think it's mandatory to land a warning indication no later than the point where we land this change.

This branch also doesn't seem to do anything to address the "Users should not be allowed to delete the key apps that ship with the phone" point from the specification in the bug description. I would personally recommend and prefer that this sort of policy should be implemented in the scope rather than in click itself, but it's up to you.