Code review comment for lp:~mvo/click/dont-crash-for-empty-db

Revision history for this message
Barry Warsaw (barry) wrote :

>This is a better version of the (rightfully) reverted r474. I currently have a single error >type for this. If you think the case "no database at all" and "invalid index in get()" should >be seperate error types I'm happy to do that.

Would a typical user be able to do something different in these two cases? If so then having separate errors makes sense. If not, then it probably doesn't effectively matter (except perhaps for API consistency, or future proofing, but OTOH YAGNI?).

« Back to merge proposal