Code review comment for lp:~mvo/click/acquire

Revision history for this message
Michael Vogt (mvo) wrote :

> Overall this looks like nice work, but I think you could productively simplify
> some things.

Thanks a lot for your detailed review. I addressed all the points you raised now.

The only one left is the blocking/non-blocking issue. The reason I made this non-blocking is that we can easily report progress about the download from the main click app this way. I created a lp:~mvo/click/acquire-asyncio that still uses a non-blocking io model but is much simpler to follow due to the use of the new python3 asyncio module.

Alternatively we can ditch some of the compatibility with the apt methods and move the progress into the method. The downside is that if/when we support parallel downloads its more difficult to present a overall progress when its done in the individual downloaders.

« Back to merge proposal