Merge lp:~mvo/aptdaemon/longlong-progress into lp:aptdaemon

Proposed by Michael Vogt
Status: Merged
Merged at revision: 672
Proposed branch: lp:~mvo/aptdaemon/longlong-progress
Merge into: lp:aptdaemon
Diff against target: 36 lines (+5/-3)
2 files modified
aptdaemon/core.py (+4/-2)
doc/source/dbus.rst (+1/-1)
To merge this branch: bzr merge lp:~mvo/aptdaemon/longlong-progress
Reviewer Review Type Date Requested Status
Aptdaemon Developers Pending
Review via email: mp+72190@code.launchpad.net

Description of the change

This make the types for bytes_{total,done} 64bit in order to follow the latest apt API change.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'aptdaemon/core.py'
--- aptdaemon/core.py 2011-08-12 09:11:03 +0000
+++ aptdaemon/core.py 2011-08-19 14:34:25 +0000
@@ -330,8 +330,9 @@
330 self.after = None330 self.after = None
331 self._role = dbus.String(role)331 self._role = dbus.String(role)
332 self._progress = dbus.Int32(0)332 self._progress = dbus.Int32(0)
333 # items_done, total_items, bytes_done, total_bytes, speed, time
333 self._progress_details = dbus.Struct((0, 0, 0, 0, 0, 0),334 self._progress_details = dbus.Struct((0, 0, 0, 0, 0, 0),
334 signature="iiiiiii")335 signature="iixxii")
335 self._progress_download = dbus.Struct(("", "", "", 0L, 0L, ""),336 self._progress_download = dbus.Struct(("", "", "", 0L, 0L, ""),
336 signature="sssxxs")337 signature="sssxxs")
337 self._exit = dbus.String(enums.EXIT_UNFINISHED)338 self._exit = dbus.String(enums.EXIT_UNFINISHED)
@@ -454,7 +455,8 @@
454 role = property(_get_role, _set_role, doc="Operation type of transaction.")455 role = property(_get_role, _set_role, doc="Operation type of transaction.")
455456
456 def _set_progress_details(self, details):457 def _set_progress_details(self, details):
457 self._progress_details = self._convert_struct(details, "iiiiii")458 # items_done, total_items, bytes_done, total_bytes, speed, time
459 self._progress_details = self._convert_struct(details, "iixxii")
458 self.PropertyChanged("ProgressDetails", self._progress_details)460 self.PropertyChanged("ProgressDetails", self._progress_details)
459461
460 def _get_progress_details(self):462 def _get_progress_details(self):
461463
=== modified file 'doc/source/dbus.rst'
--- doc/source/dbus.rst 2011-07-28 11:56:59 +0000
+++ doc/source/dbus.rst 2011-08-19 14:34:25 +0000
@@ -291,7 +291,7 @@
291291
292 *read-only*292 *read-only*
293293
294.. attribute:: ProgressDetails : (iiiiii)294.. attribute:: ProgressDetails : (iixxii)
295295
296 A list with detailed progress information:296 A list with detailed progress information:
297297

Subscribers

People subscribed via source and target branches

to status/vote changes: