Code review comment for lp:~mvo/apport/apport-checkreports-addition

Revision history for this message
Martin Pitt (pitti) wrote :

There is already apport.packaging.enabled(), so no need to redefine it again in fileutils.

The new exit status is fine for me, I'll merge that.

A new script apport-is-enabled also sounds ok to me, but I'd write it in dash, not python; calling a full python interpreter from dpkg/apt not only sounds very expensive to just check a single file, but also is prone to failures if the very thing we are reporting are failed packages.

review: Approve

« Back to merge proposal