Code review comment for lp:~music-app-dev/music-app/basic-user-metrics

Revision history for this message
Victor Thompson (vthompson) wrote :

I think your recent updates makes both the number of songs and the total minutes of music not work. I don't know if it's because both Metrics have the same name? I say we remove the total minutes of music out for the time being--unless you can figure out the issue. Also, "Haven't listening to any music today" should read "Haven't listened to any music today" (preferably something like "No time spent listening to music").

I think we need to have the number of songs played increment when a song starts playing when added to the queue. But I guess we could wait on that since you're busy.

« Back to merge proposal