Code review comment for lp:~music-app-dev/music-app/basic-user-metrics

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

But the number of tracks played 'today' is just stored in a variable. So what happens if you open the app, play some tracks, close the app and then open again and start playing other tracks.

From my understanding of the current code the counter for 'today' would be reset?

Whereas asking the database for how many have been played today would be a much more reliable solution. Except IIRC currently the recent table only stores info about playing tracks in an album or playlist? But this could easily be extended to a more generic solution if that is the case.

I talked to Lisette about what they wanted data they wanted to show, they liked the idea of showing the number of tracks played but I'll ask on Monday if they want/would like any other information.

« Back to merge proposal