Merge ~multani/cloud-init:fix-1634678 into cloud-init:master
Proposed by
Jonathan Ballet
Status: | Merged |
---|---|
Merged at revision: | 4a2b2f87ec48c227eb8fb2091dba604457cf8de8 |
Proposed branch: | ~multani/cloud-init:fix-1634678 |
Merge into: | cloud-init:master |
Diff against target: |
64 lines (+43/-1) 2 files modified
cloudinit/config/cc_disk_setup.py (+1/-1) tests/unittests/test_handler/test_handler_disk_setup.py (+42/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
cloud-init Commiters | Pending | ||
Review via email: mp+320815@code.launchpad.net |
Description of the change
Fix filesystem creation when using "partition: auto"
Accordingly to the documentation:
The ``partition`` option may also be set to ``auto``, in which this
module will search for the existance of a filesystem matching the
``label``, ``type`` and ``device`` of the ``fs_setup`` entry and
will skip creating the filesystem if one is found.
However, using this "auto" flag always recreates the partition no matter
if it has been done before or not.
This commit fixes a bug in which the "partition" attribute was always
set to None although in some cases it should not.
LP: #1634678
To post a comment you must log in.
Jonathan,
Thanks for this. It looks great.
In order to accept the change I need you to sign the contributors agreement.
HACKING.rst in the code base has more info.
http:// www.canonical. com/contributor s
Please feel free to ping me in irc or email if you have any questions.
Other than that, it looks good.
Thanks.
Scott