Merge lp:~muktupavels/ubuntu-themes/lp1423542 into lp:ubuntu-themes

[Alberts Muktupāvels]

Add some style info for unity-greeter buttons. (LP: #1423542)

Add some style info for unity-greeter buttons. (LP: #1423542)

[lp:~muktupavels/ubuntu-themes/lp1423542]

424. By Alberts Muktupāvels on 2015-02-19

Fix indentation one more time

[Alberts Muktupāvels (muktupavels)]

Related branch:
https://code.launchpad.net/~albertsmuktupavels/unity-greeter/lp1423542

[Dmitry Shachnev (mitya57)]

Minor nitpick: you use "border: 0" for option-button, but "border-width: 0" for toggle-button. Please use border-width everywhere for consistency.

[Dmitry Shachnev (mitya57)]

Also can you use some color from the theme palette instead of black?

[Alberts Muktupāvels (muktupavels)]

> Minor nitpick: you use "border: 0" for option-button, but "border-width: 0"
> for toggle-button. Please use border-width everywhere for consistency.

option-button: I am removing border completely, it is not needed for this button.
toogle-button: I am settings border-width only because for this button we need border when it is selected. This way I don't need set color and style.

I think 'border: 0' is better when removing it completely, but I can change it if needed.

[Alberts Muktupāvels (muktupavels)]

> Also can you use some color from the theme palette instead of black?

I am using same background-color rule that is already in apps/unity-greeter.css file...

[Dmitry Shachnev (mitya57)]

OK. I can land this when Robert approves your unity-greeter branch.

review: Approve

[Lars Karlitski (larsu)]

I agree. Thanks.

review: Approve

=== modified file 'Ambiance/gtk-3.0/apps/unity-greeter.css'
--- Ambiance/gtk-3.0/apps/unity-greeter.css	2015-01-27 20:47:49 +0000
+++ Ambiance/gtk-3.0/apps/unity-greeter.css	2015-02-19 13:20:32 +0000
@@ -76,3 +76,19 @@
     -gtk-icon-source: -gtk-icontheme("process-working-symbolic");
     animation: dashentry_spinner 1s infinite linear;
 }
+
+.lightdm.option-button {
+    padding: 2px;
+    background: none;
+    border: 0;
+}
+
+.lightdm.toggle-button {
+    background: none;
+    border-width: 0;
+}
+
+.lightdm.toggle-button.selected {
+    background-color: alpha (black, 0.3);
+    border-width: 1px;
+}
 
=== modified file 'Radiance/gtk-3.0/apps/unity-greeter.css'
--- Radiance/gtk-3.0/apps/unity-greeter.css	2015-01-27 20:47:49 +0000
+++ Radiance/gtk-3.0/apps/unity-greeter.css	2015-02-19 13:20:32 +0000
@@ -76,3 +76,19 @@
     -gtk-icon-source: -gtk-icontheme("process-working-symbolic");
     animation: dashentry_spinner 1s infinite linear;
 }
+
+.lightdm.option-button {
+    padding: 2px;
+    background: none;
+    border: 0;
+}
+
+.lightdm.toggle-button {
+    background: none;
+    border-width: 0;
+}
+
+.lightdm.toggle-button.selected {
+    background-color: alpha (black, 0.3);
+    border-width: 1px;
+}