Code review comment for lp:~muktupavels/lightdm/improve-multiseat-support

Revision history for this message
Robert Ancell (robert-ancell) wrote :

This fails when you run 'make check'. Specifically the xdg-seat test (cd tests ; ./test-xdg-seat). The fix is quite trivial but you should make it to show that you know the tests and think if this is the correct behaviour.

The removal of the VT check in seat_xlocal_get_active_session () doesn't really make sense. In a multi-seat case you should probably check seat_get_string_property (seat, "xdg-seat") instead and do something different than checking if any session is on this VT.

You should replace:
(xdg_seat && strcmp (xdg_seat, "seat0") == 0)
with
g_strcmp0 (xdg_seat, "seat0") == 0
as this is more readable.

review: Needs Fixing

« Back to merge proposal