Code review comment for lp:~muktupavels/compiz/gwd-settings-storage-fix-memory-leaks

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Looks fine to me - I'm not sure how I overlooked the fact that g_settings_get_string returns a copy when I first wrote this.

The only suggestion I would have is that translate_dashes_to_underscores should probably not return a value if it is modifying its argument.

review: Approve

« Back to merge proposal