Looks fine to me - I'm not sure how I overlooked the fact that g_settings_get_string returns a copy when I first wrote this.
The only suggestion I would have is that translate_dashes_to_underscores should probably not return a value if it is modifying its argument.
« Back to merge proposal
Looks fine to me - I'm not sure how I overlooked the fact that g_settings_ get_string returns a copy when I first wrote this.
The only suggestion I would have is that translate_ dashes_ to_underscores should probably not return a value if it is modifying its argument.