Merge lp:~muktupavels/compiz/cython into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4144
Merged at revision: 4145
Proposed branch: lp:~muktupavels/compiz/cython
Merge into: lp:compiz/0.9.13
Diff against target: 84 lines (+14/-12)
3 files modified
compizconfig/compizconfig-python/CMakeLists.txt (+7/-7)
compizconfig/compizconfig-python/src/compizconfig.pyx (+6/-4)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~muktupavels/compiz/cython
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Compiz Maintainers Pending
Review via email: mp+348593@code.launchpad.net

Commit message

compizconfig-python: replace pyrex with cython.

Description of the change

Replace pyrex with cython. The former does not work with python 3.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'compizconfig/compizconfig-python/CMakeLists.txt'
--- compizconfig/compizconfig-python/CMakeLists.txt 2014-11-25 19:25:20 +0000
+++ compizconfig/compizconfig-python/CMakeLists.txt 2018-06-27 10:33:58 +0000
@@ -28,17 +28,17 @@
28set (PY_BUILD_DIR lib.linux-${PROC_ARCH}-${PY_VERSION})28set (PY_BUILD_DIR lib.linux-${PROC_ARCH}-${PY_VERSION})
29set (PY_SCRIPTS_DIR scripts-${PY_VERSION})29set (PY_SCRIPTS_DIR scripts-${PY_VERSION})
30set (PY_COMPIZCONFIG_SRC ${CMAKE_CURRENT_BINARY_DIR}/compizconfig.c)30set (PY_COMPIZCONFIG_SRC ${CMAKE_CURRENT_BINARY_DIR}/compizconfig.c)
31set (PY_COMPIZCONFIG_PYREX ${CMAKE_CURRENT_SOURCE_DIR}/src/compizconfig.pyx)31set (PY_COMPIZCONFIG_CYTHON ${CMAKE_CURRENT_SOURCE_DIR}/src/compizconfig.pyx)
3232
33find_program(PYREXC_BIN pyrexc)33find_program(CYTHON_BIN cython)
34if(NOT PYREXC_BIN)34if(NOT CYTHON_BIN)
35 message(FATAL_ERROR "Can not build because pyrexc binary not found.")35 message(FATAL_ERROR "Can not build because cython binary not found.")
36endif()36endif()
3737
38add_custom_command (OUTPUT ${PY_COMPIZCONFIG_SRC}38add_custom_command (OUTPUT ${PY_COMPIZCONFIG_SRC}
39 COMMAND ${PYREXC_BIN} -o ${PY_COMPIZCONFIG_SRC} ${PY_COMPIZCONFIG_PYREX}39 COMMAND ${CYTHON_BIN} -o ${PY_COMPIZCONFIG_SRC} ${PY_COMPIZCONFIG_CYTHON}
40 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}40 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
41 DEPENDS ${PY_COMPIZCONFIG_PYREX})41 DEPENDS ${PY_COMPIZCONFIG_CYTHON})
4242
43file (READ ${CMAKE_SOURCE_DIR}/VERSION COMPIZ_RELEASE_VERSION LIMIT 12 OFFSET 0)43file (READ ${CMAKE_SOURCE_DIR}/VERSION COMPIZ_RELEASE_VERSION LIMIT 12 OFFSET 0)
44string (STRIP ${COMPIZ_RELEASE_VERSION} COMPIZ_RELEASE_VERSION)44string (STRIP ${COMPIZ_RELEASE_VERSION} COMPIZ_RELEASE_VERSION)
@@ -50,7 +50,7 @@
50include_directories (${PYTHON_INCLUDE_DIRS}50include_directories (${PYTHON_INCLUDE_DIRS}
51 ${COMPIZCONFIG_INCLUDE_DIRS})51 ${COMPIZCONFIG_INCLUDE_DIRS})
5252
53# pyrex generates code that does type-punning, this trips53# cython generates code that does type-punning, this trips
54# up -Werror54# up -Werror
55set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-strict-aliasing")55set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-strict-aliasing")
5656
5757
=== modified file 'compizconfig/compizconfig-python/src/compizconfig.pyx'
--- compizconfig/compizconfig-python/src/compizconfig.pyx 2012-09-05 08:05:54 +0000
+++ compizconfig/compizconfig-python/src/compizconfig.pyx 2018-06-27 10:33:58 +0000
@@ -164,8 +164,8 @@
164 Bool extensible164 Bool extensible
165165
166cdef struct CCSSettingListInfo:166cdef struct CCSSettingListInfo:
167 CCSSettingType listType167 CCSSettingType listType
168 void * listInfo # actually CCSSettingInfo *, works around pyrex168 CCSSettingInfo * listInfo
169169
170cdef struct CCSSettingActionInfo:170cdef struct CCSSettingActionInfo:
171 Bool internal171 Bool internal
@@ -974,7 +974,8 @@
974974
975 property EnableConflicts:975 property EnableConflicts:
976 def __get__ (self):976 def __get__ (self):
977 cdef CCSPluginConflictList * pl, * pls977 cdef CCSPluginConflictList * pl
978 cdef CCSPluginConflictList * pls
978 cdef CCSPluginConflict * pc979 cdef CCSPluginConflict * pc
979 cdef CCSPluginList * ppl980 cdef CCSPluginList * ppl
980 cdef CCSPlugin * plg981 cdef CCSPlugin * plg
@@ -1002,7 +1003,8 @@
10021003
1003 property DisableConflicts:1004 property DisableConflicts:
1004 def __get__ (self):1005 def __get__ (self):
1005 cdef CCSPluginConflictList * pl, * pls1006 cdef CCSPluginConflictList * pl
1007 cdef CCSPluginConflictList * pls
1006 cdef CCSPluginConflict * pc1008 cdef CCSPluginConflict * pc
1007 cdef CCSPluginList * ppl1009 cdef CCSPluginList * ppl
1008 cdef CCSPlugin * plg1010 cdef CCSPlugin * plg
10091011
=== modified file 'debian/control'
--- debian/control 2017-04-11 14:01:44 +0000
+++ debian/control 2018-06-27 10:33:58 +0000
@@ -52,7 +52,7 @@
52 libprotobuf-dev,52 libprotobuf-dev,
53 protobuf-compiler,53 protobuf-compiler,
54 python-all-dev,54 python-all-dev,
55 python-pyrex,55 cython,
56 gsettings-desktop-schemas-dev,56 gsettings-desktop-schemas-dev,
57 xserver-xorg-dev (>= 0.7.0),57 xserver-xorg-dev (>= 0.7.0),
58Standards-Version: 3.9.858Standards-Version: 3.9.8

Subscribers

People subscribed via source and target branches