Merge lp:~muktupavels/compiz/cmp0005 into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 4176
Merged at revision: 4176
Proposed branch: lp:~muktupavels/compiz/cmp0005
Merge into: lp:compiz/0.9.13
Prerequisite: lp:~muktupavels/compiz/cmp0003
Diff against target: 192 lines (+28/-33)
11 files modified
cmake/CompizCommon.cmake (+0/-1)
cmake/plugin_extensions/CompizGenInstallData.cmake (+1/-1)
compizconfig/libcompizconfig/src/CMakeLists.txt (+6/-6)
compizconfig/libcompizconfig/tests/CMakeLists.txt (+1/-1)
gtk/window-decorator/CMakeLists.txt (+3/-2)
plugins/dbus/CMakeLists.txt (+2/-2)
src/CMakeLists.txt (+3/-3)
src/plugin/CMakeLists.txt (+3/-3)
src/plugin/tests/CMakeLists.txt (+3/-5)
src/privatescreen/tests/CMakeLists.txt (+3/-5)
src/region/tests/CMakeLists.txt (+3/-4)
To merge this branch: bzr merge lp:~muktupavels/compiz/cmp0005
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+350715@code.launchpad.net

Commit message

Don't set CMP0005 policy to OLD.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cmake/CompizCommon.cmake'
--- cmake/CompizCommon.cmake 2018-07-24 09:39:24 +0000
+++ cmake/CompizCommon.cmake 2018-07-24 09:39:24 +0000
@@ -13,7 +13,6 @@
13#### policies13#### policies
1414
15cmake_policy (SET CMP0002 OLD)15cmake_policy (SET CMP0002 OLD)
16cmake_policy (SET CMP0005 OLD)
17cmake_policy (SET CMP0011 OLD)16cmake_policy (SET CMP0011 OLD)
18cmake_policy (SET CMP0022 OLD)17cmake_policy (SET CMP0022 OLD)
1918
2019
=== modified file 'cmake/plugin_extensions/CompizGenInstallData.cmake'
--- cmake/plugin_extensions/CompizGenInstallData.cmake 2013-02-20 13:55:12 +0000
+++ cmake/plugin_extensions/CompizGenInstallData.cmake 2018-07-24 09:39:24 +0000
@@ -23,5 +23,5 @@
23 DESTINATION ${PLUGIN_DATADIR}23 DESTINATION ${PLUGIN_DATADIR}
24 )24 )
25 endif (_install_plugin_${COMPIZ_CURRENT_PLUGIN})25 endif (_install_plugin_${COMPIZ_CURRENT_PLUGIN})
26 list (APPEND COMPIZ_DEFINITIONS_ADD "-DDATADIR='\"${PLUGIN_DATADIR}\"'")26 list (APPEND COMPIZ_DEFINITIONS_ADD -DDATADIR="${PLUGIN_DATADIR}")
27endif ()27endif ()
2828
=== modified file 'compizconfig/libcompizconfig/src/CMakeLists.txt'
--- compizconfig/libcompizconfig/src/CMakeLists.txt 2013-02-21 05:21:26 +0000
+++ compizconfig/libcompizconfig/src/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -24,12 +24,12 @@
2424
25add_definitions (25add_definitions (
26 -DHAVE_CONFIG_H26 -DHAVE_CONFIG_H
27 -DPLUGINDIR=\\\"${COMPIZ_PLUGINDIR}\\\"27 -DPLUGINDIR="${COMPIZ_PLUGINDIR}"
28 -DIMAGEDIR=\\\"${COMPIZ_IMAGEDIR}\\\"28 -DIMAGEDIR="${COMPIZ_IMAGEDIR}"
29 -DMETADATADIR=\\\"${COMPIZ_METADATADIR}\\\"29 -DMETADATADIR="${COMPIZ_METADATADIR}"
30 -DSYSCONFDIR=\\\"${COMPIZ_SYSCONFDIR}\\\"30 -DSYSCONFDIR="${COMPIZ_SYSCONFDIR}"
31 -DDATADIR=\\\"${COMPIZ_DATADIR}\\\"31 -DDATADIR="${COMPIZ_DATADIR}"
32 -DLIBDIR=\\\"${COMPIZ_LIBDIR}\\\"32 -DLIBDIR="${COMPIZ_LIBDIR}"
33)33)
3434
35if (HAVE_PROTOBUF)35if (HAVE_PROTOBUF)
3636
=== modified file 'compizconfig/libcompizconfig/tests/CMakeLists.txt'
--- compizconfig/libcompizconfig/tests/CMakeLists.txt 2015-07-30 19:56:19 +0000
+++ compizconfig/libcompizconfig/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -11,7 +11,7 @@
1111
12set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")12set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
1313
14add_definitions (-DSYSCONFDIR=\\\"${COMPIZ_SYSCONFDIR}\\\")14add_definitions (-DSYSCONFDIR="${COMPIZ_SYSCONFDIR}")
1515
16add_executable (compizconfig_test_ccs_object16add_executable (compizconfig_test_ccs_object
17 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_test_ccs_object.cpp)17 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_test_ccs_object.cpp)
1818
=== modified file 'gtk/window-decorator/CMakeLists.txt'
--- gtk/window-decorator/CMakeLists.txt 2016-06-08 10:34:32 +0000
+++ gtk/window-decorator/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -13,10 +13,11 @@
13 ${DBUS_GLIB_INCLUDE_DIRS}13 ${DBUS_GLIB_INCLUDE_DIRS}
14 )14 )
1515
16 string(REPLACE ";" " " LINGUAS "${ALL_LINGUAS}")
16 add_definitions (17 add_definitions (
17 -DHAVE_CONFIG_H18 -DHAVE_CONFIG_H
18 -DALL_LINGUAS=\"${ALL_LINGUAS}\"19 -DALL_LINGUAS=${LINGUAS}
19 -DLOCALEDIR=\\\"${datadir}/locale\\\"20 -DLOCALEDIR="${datadir}/locale"
20 )21 )
2122
22 link_directories (23 link_directories (
2324
=== modified file 'plugins/dbus/CMakeLists.txt'
--- plugins/dbus/CMakeLists.txt 2010-04-23 17:16:17 +0000
+++ plugins/dbus/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -4,8 +4,8 @@
44
5add_definitions (5add_definitions (
6 -DHAVE_CONFIG_H6 -DHAVE_CONFIG_H
7 -DPLUGINDIR=\\\"${compiz_plugindir}\\\"7 -DPLUGINDIR="${compiz_plugindir}"
8 -DMETADATADIR=\\\"${compiz_metadatadir}\\\"8 -DMETADATADIR="${compiz_metadatadir}"
9)9)
1010
11compiz_plugin (dbus PKGDEPS dbus-1 libxml-2.0)11compiz_plugin (dbus PKGDEPS dbus-1 libxml-2.0)
1212
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2013-01-03 16:05:26 +0000
+++ src/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -82,9 +82,9 @@
8282
83add_definitions (83add_definitions (
84 -DHAVE_CONFIG_H84 -DHAVE_CONFIG_H
85 -DPLUGINDIR=\\\"${compiz_plugindir}\\\"85 -DPLUGINDIR="${compiz_plugindir}"
86 -DSHAREDIR=\\\"${compiz_sharedir}\\\"86 -DSHAREDIR="${compiz_sharedir}"
87 -DMETADATADIR=\\\"${compiz_metadatadir}\\\"87 -DMETADATADIR="${compiz_metadatadir}"
88)88)
8989
90get_property (CORE_MOD_LIBRARY_DIRS90get_property (CORE_MOD_LIBRARY_DIRS
9191
=== modified file 'src/plugin/CMakeLists.txt'
--- src/plugin/CMakeLists.txt 2012-09-29 15:35:59 +0000
+++ src/plugin/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -26,9 +26,9 @@
2626
27add_definitions (27add_definitions (
28 -DHAVE_CONFIG_H28 -DHAVE_CONFIG_H
29 -DPLUGINDIR=\\\"${compiz_plugindir}\\\"29 -DPLUGINDIR="${compiz_plugindir}"
30 -DSHAREDIR=\\\"${compiz_sharedir}\\\"30 -DSHAREDIR="${compiz_sharedir}"
31 -DMETADATADIR=\\\"${compiz_metadatadir}\\\"31 -DMETADATADIR="${compiz_metadatadir}"
32)32)
3333
34SET( SRCS ${compiz_SOURCE_DIR}/src/plugin.cpp )34SET( SRCS ${compiz_SOURCE_DIR}/src/plugin.cpp )
3535
=== modified file 'src/plugin/tests/CMakeLists.txt'
--- src/plugin/tests/CMakeLists.txt 2013-04-22 14:30:55 +0000
+++ src/plugin/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -10,12 +10,11 @@
1010
11add_definitions (11add_definitions (
12 -DHAVE_CONFIG_H12 -DHAVE_CONFIG_H
13 -DPLUGINDIR=\\\"${compiz_plugindir}\\\"13 -DPLUGINDIR="${compiz_plugindir}"
14 -DSHAREDIR=\\\"${compiz_sharedir}\\\"14 -DSHAREDIR="${compiz_sharedir}"
15 -DMETADATADIR=\\\"${compiz_metadatadir}\\\"15 -DMETADATADIR="${compiz_metadatadir}"
16)16)
1717
18
19add_executable( 18add_executable(
20 compiz_plugin_test19 compiz_plugin_test
21 20
@@ -33,4 +32,3 @@
33)32)
3433
35compiz_discover_tests ( compiz_plugin_test COVERAGE compiz_plugin compiz_core )34compiz_discover_tests ( compiz_plugin_test COVERAGE compiz_plugin compiz_core )
36
3735
=== modified file 'src/privatescreen/tests/CMakeLists.txt'
--- src/privatescreen/tests/CMakeLists.txt 2013-04-22 14:30:55 +0000
+++ src/privatescreen/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -26,15 +26,13 @@
26 ${Boost_INCLUDE_DIRS}26 ${Boost_INCLUDE_DIRS}
27)27)
2828
29
30add_definitions (29add_definitions (
31 -DHAVE_CONFIG_H30 -DHAVE_CONFIG_H
32 -DPLUGINDIR=\\\"${compiz_plugindir}\\\"31 -DPLUGINDIR="${compiz_plugindir}"
33 -DSHAREDIR=\\\"${compiz_sharedir}\\\"32 -DSHAREDIR="${compiz_sharedir}"
34 -DMETADATADIR=\\\"${compiz_metadatadir}\\\"33 -DMETADATADIR="${compiz_metadatadir}"
35)34)
3635
37
38add_executable( 36add_executable(
39 compiz_privatescreen_test37 compiz_privatescreen_test
40 38
4139
=== modified file 'src/region/tests/CMakeLists.txt'
--- src/region/tests/CMakeLists.txt 2013-04-22 14:30:55 +0000
+++ src/region/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
@@ -9,12 +9,11 @@
99
10add_definitions (10add_definitions (
11 -DHAVE_CONFIG_H11 -DHAVE_CONFIG_H
12 -DPLUGINDIR=\\\"${compiz_plugindir}\\\"12 -DPLUGINDIR="${compiz_plugindir}"
13 -DSHAREDIR=\\\"${compiz_sharedir}\\\"13 -DSHAREDIR="${compiz_sharedir}"
14 -DMETADATADIR=\\\"${compiz_metadatadir}\\\"14 -DMETADATADIR="${compiz_metadatadir}"
15)15)
1616
17
18add_executable( 17add_executable(
19 compiz_region_test18 compiz_region_test
20 19

Subscribers

People subscribed via source and target branches