Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
#### Brief overview of PR changes/additions
In fact this ought to be happening in other cases as well when using the
"Move to position" 2D Mapper context menu option. It is a result of
setting the `Qt::WA_DeleteOnClose` attribute on the `QDialog` used to
get the user's input and using `QDialog::exect()` in order to "run" the
dialog. As a result it deletes itself when the user clicks the "Okay"
button but Mudlet has been trying (and crashing when it cannot) to read
the text contents of the `QLineEdit`s that the user has typed their
input into after that point!
The fix is to NOT set that attribute. To ensure that the dialog is
cleared from memory after use (as #6531 was trying to do) we must ensure
that the dialog is destroyed AFTER the details have been gathered - or
even if they are not because "Cancel" has been clicked instead and the
safest method to do that is to call `QObject::deleteLater()` on it when
we have finished with it - then it gets scheduled for destruction and
the underlying Qt code does that when "control returns to the main event
loop" - importantly it is safe to call that more than once on the same
object which is not always the case for the core C++ `delete X`
operation).
#### Motivation for adding to Mudlet
As the title and related issue suggests, to stop a fatal seg. fault when
one or more rooms are moved in the 2D mapper with the "Move to position"
context menu action is used.
#### Other info (issues closed, discussion etc)
This should close #6932. As a check I have reviewed all the other places
where `QDialog::exec()` is used and I have determined to my satisfaction
that there are no other cases in our code where this could also happen.
Further investigation shows that the bug was introduced by #6531
inserted into the code base by @Kebap in February this year (so will
affect **4.17.x** releases up until this fix goes in).
Signed-off-by: Stephen Lyons <email address hidden>
47ac4bd...
by
Vadim Peretokin <email address hidden>
Infrastructure: fix codeql 3rd party dependency filtering (#6930)
<!-- Keep the title short & concise so anyone non-technical can
understand it,
the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Fix codeql 3rd party dependency filtering
#### Motivation for adding to Mudlet
Fix CodeQL action, which has [been
broken](https://github.com/Mudlet/Mudlet/actions/workflows/codeql-analysis.yml)
for a month or so
#### Other info (issues closed, discussion etc)
Default behaviour of the action was changed to upload results right away
- this we couldn't filter them
36f6b36...
by
mudlet-machine-account <email address hidden>
Improve: New Crowdin updates (#6931)
69dd900...
by
mudlet-machine-account <email address hidden>
Infrastructure: Update text for translation in Crowdin (#6929)
#### Brief overview of PR changes/additions
:crown: An automated PR to make new text available for translation in
Crowdin from refs/heads/development
(1474a1e0fa9cfbf8b9f639243d65d0f9bef52da2).
#### Motivation for adding to Mudlet
So translators can translate the new text before the upcoming release.
Infrastructure: migrate more texts to later translation disambiguation form (#6924)
#### Brief overview of PR changes/additions
Moves a few translation disambiguation comments out of
`QObject::tr(...)` calls to a special comment before them.
#### Motivation for adding to Mudlet
Completion of (bountied!) task set out in #5522.
#### Other info (issues closed, discussion etc)
These texts were missed by #6862 possibly because they were in other PRs
at the time...
Signed-off-by: Stephen Lyons <email address hidden>
#### Brief overview of PR changes/additions
This is to help the end-user identify and cross-reference the ID numbers
used for permanent items in scripts AND the editor.
#### Motivation for adding to Mudlet
This PR should, perhaps, be considered alongside #6726 and #6742.
Improve: save and restore multi-view mode between Mudlet application runs (#6923)
#### Brief overview of PR changes/additions
Although the situation as described in the related issue seems to be the
opposite to how the OP reported it, it is true that the multi-view mode
is NOT saved between Mudlet runs. This PR fixes that so that the
multi-view mode **is** now saved between runs so that if it is set when
Mudlet closes it will then be applied in a future run once a second
profile is opened.
#### Motivation for adding to Mudlet
Improvement in Mudlet operation
#### Other info (issues closed, discussion etc)
This will, I think, close #6917.
Signed-off-by: Stephen Lyons <email address hidden>
