View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/mudlet

See all merge proposals.

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://github.com/Mudlet/Mudlet.git.

The next import is scheduled to run .

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-3 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-3 and finished taking 1 minute — see the log

Branches

Name Last Modified Last Commit
development 2025-07-12 13:44:39 UTC
Fix: getTextFormat() Boundary Checks and Add Comprehensive Test Coverage (#7883)

Author: Mike Conley
Author Date: 2025-07-12 13:44:39 UTC

Fix: getTextFormat() Boundary Checks and Add Comprehensive Test Coverage (#7883)

#### Brief overview of PR changes/additions

• **Fixed race conditions** in TConsole::getTextAttributes() by taking
coordinate snapshots to prevent Time-of-Check-Time-of-Use (TOCTOU)
issues during buffer access
• **Added cursor fallback** when no selection is active, ensuring
getTextFormat() works consistently with getFgColor() and getBgColor()
• **Fixed boundary checking** that was incorrectly using "size() - 1"
causing failures when selecting the last character in a line (core issue
in bug #5744)
• **Enhanced error handling** in getTextFormat() Lua function with
proper console validation and clearer error messages
• **Added comprehensive test suite** with 1000+ lines of tests covering
edge cases, race conditions, and exact bug reproduction scenarios
• **Added documentation** in TBuffer clarifying proper formatting usage
patterns

#### Motivation for adding to Mudlet

The original issue showed that getTextFormat() would fail when selecting
the last character of a line, while getFgColor() and getBgColor() worked
correctly in the same situation. This inconsistency was caused by an
off-by-one error in boundary checking (`x >= size() - 1` instead of `x
>= size()`) and lack of cursor fallback when no selection was active.
Additionally, race conditions could occur when buffer state changed
between coordinate validation and character access. This PR ensures all
text formatting functions behave consistently and reliably.

#### Other info (issues closed, discussion etc)

• **Closes** [getTextFormat erroneously errors on last character in the
line if selected by itself.
#5744](https://github.com/Mudlet/Mudlet/issues/5744)
• **Implements fix suggested by [@jarlyyn](https://github.com/jarlyyn)**
who identified the root cause in the boundary checking logic
• **Addresses [@SlySven](https://github.com/SlySven)'s concerns** about
handling empty lines and buffer consistency
• **Adds comprehensive test coverage** requested by
[@vadi2](https://github.com/vadi2) including exact reproduction of the
original bug scenario
• **May unblock** [copy2decho ignores italic/bold/underline formatting
#5589](https://github.com/Mudlet/Mudlet/issues/5589) per
[@demonnic](https://github.com/demonnic)
• **Includes extensive diagnostic testing** with 41 test scenarios that
provide debugging output without breaking the build

The fix uses coordinate snapshots to prevent race conditions, adds
proper cursor fallback behavior, and corrects the boundary logic that
was excluding valid last-character selections.

l10n_development 2025-07-11 10:08:57 UTC
New translations mudlet.ts (Italian)

Author: mudlet-machine-account
Author Date: 2025-07-11 10:08:57 UTC

New translations mudlet.ts (Italian)

dependabot/github_actions/lukka/get-cmake-4.0.3 2025-06-20 16:54:41 UTC
Infrastructure: Bump lukka/get-cmake from 3.20.1 to 4.0.3

Author:
Author Date: 2025-06-20 16:54:41 UTC

Infrastructure: Bump lukka/get-cmake from 3.20.1 to 4.0.3

Bumps [lukka/get-cmake](https://github.com/lukka/get-cmake) from 3.20.1 to 4.0.3.
- [Release notes](https://github.com/lukka/get-cmake/releases)
- [Commits](https://github.com/lukka/get-cmake/compare/v3.20.1...v4.0.3)

---
updated-dependencies:
- dependency-name: lukka/get-cmake
  dependency-version: 4.0.3
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Enable-.ui-sorting-workflow-to-be-run-manually 2025-06-19 06:47:24 UTC
Merge branch 'development' into Enable-.ui-sorting-workflow-to-be-run-manually

Author: Zooka
Author Date: 2025-06-19 06:47:24 UTC

Merge branch 'development' into Enable-.ui-sorting-workflow-to-be-run-manually

ui-sort 2025-06-11 14:50:56 UTC
Standarize UI files

Author: Delwing
Author Date: 2025-06-11 14:50:56 UTC

Standarize UI files

add-tags-widget 2025-06-11 10:01:46 UTC
Merge branch 'development' into add-tags-widget

Author: Zooka
Author Date: 2025-06-11 10:01:46 UTC

Merge branch 'development' into add-tags-widget

update-edbee 2025-05-21 01:11:28 UTC
Merge branch 'development' into update-edbee

Author: Stephen Lyons
Author Date: 2025-05-21 01:11:28 UTC

Merge branch 'development' into update-edbee

dependabot/github_actions/ZedThree/clang-tidy-review-0.21.0 2025-04-11 16:55:36 UTC
Infrastructure: Bump ZedThree/clang-tidy-review from 0.20.1 to 0.21.0

Author:
Author Date: 2025-04-11 16:55:36 UTC

Infrastructure: Bump ZedThree/clang-tidy-review from 0.20.1 to 0.21.0

Bumps [ZedThree/clang-tidy-review](https://github.com/zedthree/clang-tidy-review) from 0.20.1 to 0.21.0.
- [Release notes](https://github.com/zedthree/clang-tidy-review/releases)
- [Changelog](https://github.com/ZedThree/clang-tidy-review/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zedthree/clang-tidy-review/compare/v0.20.1...v0.21.0)

---
updated-dependencies:
- dependency-name: ZedThree/clang-tidy-review
  dependency-version: 0.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

test-edbee-autocomplete 2025-03-27 12:23:17 UTC
Test edbee with new focus changes

Author: Vadim Peretokin
Author Date: 2025-03-27 12:23:17 UTC

Test edbee with new focus changes

add-sentry-crash-reporting 2025-02-26 02:17:08 UTC
Merge branch 'development' into add-sentry-crash-reporting

Author: Vadim Peretokin
Author Date: 2025-02-26 02:17:08 UTC

Merge branch 'development' into add-sentry-crash-reporting

release-4.19 2025-01-01 15:38:10 UTC
4.19.1 hotfix release

Author: Vadim Peretokin
Author Date: 2025-01-01 15:38:10 UTC

4.19.1 hotfix release

show-stacktrace-on-crash 2024-12-25 07:32:19 UTC
Merge branch 'development' into show-stacktrace-on-crash

Author: Vadim Peretokin
Author Date: 2024-12-25 07:32:19 UTC

Merge branch 'development' into show-stacktrace-on-crash

restrict-azure-login 2024-12-09 14:29:13 UTC
Infrastructure: make TRoom coordinates private (#7539)

Author: Stephen Lyons
Author Date: 2024-12-09 14:29:13 UTC

Infrastructure: make TRoom coordinates private (#7539)

#### Summary of PR Changes/Additions
Makes the coordinate members of the `TRoom` class private so that access
to them can be tracked via methods to set and get them.

#### Motivation for Adding to Mudlet
This is so that the setters can then subsequently include any extra code
that needs to be aware when the room is moved. I intend to improve the
detection of rooms being placed in the same position but realised this
would be a good preliminary step.

#### Additional Information (related issues, discussions, etc.)
Removes some dead code setting but not using `(int) quads` and `(int)
verts` in `(void) GLWidget::paintGL()`

Also using the mouse to drag and thus move selected rooms when those
rooms were on different levels would squash them all down to be on the
same z-coordinate as the "highlighted centre of the selection" room.
This is not as helpful it might seem and instead increased the
likelihood of causing room collisions - so now each room will retain
it's z coordinate if it is not on the same level as the centre of the
multiple room selection.

Also move code that likely needs to be run whenever rooms are
added/removed/moved within an area to a common block of code (`(void)
TArea::clean()`) to help keep things DRY. I intend to put code to update
a per area record of rooms that are in the same place within that block
in the future - so that the record can be reused without having to be
repeatedly recalculated, especially in the paint event for the 2D
mapper.

---------

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

check-when-installer-is-available 2024-09-17 07:23:46 UTC
Add initial FileLockChecker class

Author: Vadim Peretokin
Author Date: 2024-09-17 07:23:46 UTC

Add initial FileLockChecker class

release-4.18 2024-07-29 19:11:51 UTC
Calculate sha256 for sources as well

Author: Vadim Peretokin
Author Date: 2024-07-29 19:11:51 UTC

Calculate sha256 for sources as well

add-runtime-update-switch 2024-07-15 17:46:54 UTC
Start on a runtime switch to disable updates

Author: Vadim Peretokin
Author Date: 2024-07-15 17:46:54 UTC

Start on a runtime switch to disable updates

Mainly intended for Steam

build 2024-07-11 05:07:55 UTC
Infrastructure: Update text for translation in Crowdin (#7202)

Author: mudlet-machine-account
Author Date: 2024-07-11 05:07:55 UTC

Infrastructure: Update text for translation in Crowdin (#7202)

#### Brief overview of PR changes/additions
:crown: An automated PR to make new text available for translation in
Crowdin from refs/heads/development
(01fa2db36c91bf6f29d7953a4098a0624fdd0d80).
#### Motivation for adding to Mudlet
So translators can translate the new text before the upcoming release.

Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>

speedup-map-panning 2024-06-23 05:48:53 UTC
Merge branch 'development' into speedup-map-panning

Author: Vadim Peretokin
Author Date: 2024-06-23 05:48:53 UTC

Merge branch 'development' into speedup-map-panning

add-flatpak-pipelines 2024-01-30 22:44:06 UTC
Try installing pinentry first

Author: Vadim Peretokin
Author Date: 2024-01-30 22:44:06 UTC

Try installing pinentry first

table.is_field 2024-01-26 12:03:50 UTC
Merge branch 'development' into table.is_field

Author: Kebap
Author Date: 2024-01-26 12:03:50 UTC

Merge branch 'development' into table.is_field

reinstall-default-packages 2023-12-24 14:42:58 UTC
WIP

Author: Vadim Peretokin
Author Date: 2023-12-24 14:42:58 UTC

WIP

release-4.17 2023-04-02 12:13:38 UTC
4.17.2 bugfix

Author: Vadim Peretokin
Author Date: 2023-04-02 12:13:38 UTC

4.17.2 bugfix

fix_chinese_and_auto_wrapping 2022-11-14 19:12:44 UTC
Revert "Infrastructure: Revert 6207 and 6277 (#6423)"

Author: Demonnicus
Author Date: 2022-11-14 19:12:44 UTC

Revert "Infrastructure: Revert 6207 and 6277 (#6423)"

This reverts commit 4a9e1a4941a63392e20ac0c93068dcc8e87c2963.

release-4.14 2021-11-22 07:08:19 UTC
.1 update for tabs in editor

Author: Vadim Peretokin
Author Date: 2021-11-22 07:08:19 UTC

.1 update for tabs in editor

refactor_macros 2021-03-07 07:11:20 UTC
typo

Author: Kebap
Author Date: 2021-03-07 07:11:20 UTC

typo

main 2020-03-10 19:14:06 UTC
Merge pull request #3419 from Mudlet/development

Author: Vadim Peretokin
Author Date: 2020-03-10 19:14:06 UTC

Merge pull request #3419 from Mudlet/development

Update master with latest 4.6.1 release

126 of 26 results

Other repositories

Name Last Modified
lp:mudlet 5 hours ago
11 of 1 result
You can't create new repositories for Mudlet.