BugFix: try and make connectExitStub(...) work as per the API (#5395)
* BugFix: try and make connectExitStub(...) work as per the API
This PR should enable connectExitStub(...) to work as close to the existing
published API as possible:
* connectExitStub((integer) fromRoomID, (integer)toRoomID, (integer or string) direction)
where direction is the initial(s) or full, lower-case, un-hypenated ENGLISH
word for one of the 12 normal exit directions - this will make a two way
exit between the given direction of the fromRoomID room to the toRoomID
room AND the corresponding reverse direction exit from the toRoomID room.
The rooms need not be the same Area but they must BOTH have stub exits in
the required direction.
* `connectExitStub((integer) fromRoomID, (integer) toRoomID)` - this will
make a two way exit between the fromRoomID room to the toRoomID room AND
the corresponding reverse direction exit from the toRoomID room. The rooms
need not be the same Area but the fromRoomID must have only ONE stub exit
with an opposite (reverse) direction one in the toRoomID one - either room
can have other stub exits. Should there be more than one pair of stub exits
a nil + error message will be produced listing the choices for the
direction that can be passed to the three argument function call to make
the exits wanted.
* `connectExitStub((integer) fromRoomID, (integer or string) dirction)`
- this will make a two way exit between the stub exit in the fromRoomID
room to the NEAREST other room IN THE SAME AREA which has a stub exit in
the reverse direction and which lies in the correct relative position
(except for the `in`/`out` directions where this is not relevant). Should
the direction be given as an integer in the range 1 to 12 this will be
rejected (via a nil + error message) because it is ambiguous then whether
the number represents a direction or a toRoomID. Potentially unlike the
prior code, this version properly detects whether a string or number is
supplied as the direction argument.
Also:
* to allow the reporting of the direction as a number and a string in error
messages the `(QString) TRoom::dirCodeToString(const int)` method has been
made `static` so that it can be used in the `TLuaInterpreter` class.
* as indirectly mentioned above
`(int) TLuaInterpreter::dirToNumber(lua_State*, int)` has been revised to
check for a string or integer argument being examined - the prior code
may not work as anticipated because it used `lua_isxxxx(...)` functions
which can coerce the value they are dealing with (a number can be coerced
into a string) - which messes with the logic.
* in places in the revised methods the integer constant values have been
replaced with the `DIR_XXXXX` values defined in the `TRoom` class header
file.
* to simplify (!) the coding the three different forms of the Lua API are
implemented in three separate `(QString) TMap::connectExitStubByXxxx(...)
methods which collectively replace the original
`(void) TMap::connectExitStub(...)` one. They are responsible for
generating most of the Lua API error messages for this function and they
indicate success by returning an empty string.
This should close #2386.
Revise: add a suggestion to the user on how to proceed on a message
8061fbc...
by
Damian Monogue <email address hidden>
More debug and error printing options (#5457)
* Add printDebug and printError lua wrappers around debugc, and error to provide more information, including stacktrace, for your debug and error messages.
* Add links to where the documentation will reside, once it is written.
* Add tests for printDebug and printError
* Make errorc internal only for use by printError, and adjust it so its formatting is more in line with the existing errors messages
* allow errorc to be global if and only if the profile is 'Mudlet self-test' in order for tests to be able to spy on it.
* Make tests work with windows or linux path delimiters
46b6453...
by
Damian Monogue <email address hidden>
Gmod busted tests (#5472)
* Add busted tests for gmod module
585969d...
by
Manuel Wegmann <email address hidden>
Add dark theme toggle to preferences (#4984)
bb39844...
by
Damian Monogue <email address hidden>
Fix copy2decho() on empty lines (#5465)
* Handle edge case where copy2decho() is called against an empty line
* Add test for the case I just fixed
* Ensure the spy was called.
6e72e1f...
by
"dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Bump actions/setup-node from 2.4.0 to 2.4.1 (#5470)
